git-for-windows / git-for-windows-automation

A few GitHub workflows and support code to help with Git for Windows' day-to-day tasks
10 stars 9 forks source link

open-pr: try harder to find a corresponding `component-update` ticket #9

Closed dscho closed 1 year ago

dscho commented 1 year ago

When opening a Pull Request, we would like to automatically close the corresponding component-update ticket, if there is any.

Unfortunately, it is not quite trivial to search for such tickets. One frustrating aspect is that some updates have the version number prefixed with v while others do not. And the search on GitHub is a bit strict about that: if you search for 0.10.1, you won't find a ticket mentioning v0.10.1 and the opposite is also true.

We already started to special-case at least Git LFS, but it's a bit of a whack-a-mole to do that for all components we track in Git for Windows.

Let's instead search for the version in both forms: both prefixed with v as well as without.

This addresses https://github.com/git-for-windows/gfw-helper-github-app/issues/18