git-for-windows / git

A fork of Git containing Windows-specific patches.
http://gitforwindows.org/
Other
8.19k stars 2.49k forks source link

Fix `git-artifacts` builds after the recent upgrade to GCC v14.1 #4953

Closed dscho closed 1 month ago

dscho commented 1 month ago

The build fails thusly:

archive-zip.c: In function 'dos_time':
archive-zip.c:612:9: error: implicit declaration of function 'localtime_r'; did you mean 'localtime_s'? [-Wimplicit-function-declaration]
  612 |         localtime_r(&time, &tm);
      |         ^~~~~~~~~~~
      |         localtime_s

This might not be the only thing that is currently broken, so let's make sure to fix all of the issues preventing GCC v14.1 to build Git for Windows correctly.