search

git-for-windows / git

A fork of Git containing Windows-specific patches.
http://gitforwindows.org/
Other
8.19k stars 2.49k forks source link

package-versions.txt file missing from build-extra and 2.45.1-32-bit.7z.exe #4955

Closed mcgitty closed 1 month ago

mcgitty commented 1 month ago

For the 2.45.1 release, file 'package-versions-2.45.1.txt' is missing from repo folder: build-extra/versions

File 'package-versions.txt' does exist in release asset: PortableGit-2.45.1-64-bit.7z.exe. However, that file is missing from the 32-bit asset: PortableGit-2.45.1-32-bit.7z.exe

Something related to generating the package-versions.txt file is broken for this release.

dscho commented 1 month ago

I simply didn't get around to doing it earlier, because of the many follow-up tasks I had to do (and still have to). Now I pushed the changes: https://github.com/git-for-windows/build-extra/compare/90ca2c156...51c8a7664

I honestly do not know why it's not in the 32-bit version, though. Did you see that happen before?

mcgitty commented 1 month ago

No, only in that 32-bit asset. For example, that file exists in the previous version asset PortableGit-2.45.0-32-bit.7z.exe. That means only one of two issues reported here is fixed, unless it shows up again in newer 32-bit assets.

dscho commented 1 month ago

That means only one of two issues reported here is fixed, unless it shows up again in newer 32-bit assets.

I've opened https://github.com/git-for-windows/build-extra/pull/555 that I still would love for you to review @mcgitty.