git-for-windows / git

A fork of Git containing Windows-specific patches.
http://gitforwindows.org/
Other
8.39k stars 2.54k forks source link

CI failures on macos targets #5159

Closed derrickstolee closed 1 month ago

derrickstolee commented 1 month ago

I'm not sure if this is new, but it doesn't seem to be related to my changes in my PR. The PR builds are failing for all macos targets.

Here is one sample error log, though they are all the same:

=== Failed test: t5559-http-fetch-smart-http2 ===
The full logs are in the 'print test failures' step below.
See also the 'failed-tests-*' artifacts attached to this run.
Error: failed: t5559.30 large fetch-pack requests can be sent using chunked encoding
failure: t5559.30 large fetch-pack requests can be sent using chunked encoding 
    GIT_TRACE_CURL=true git -c http.postbuffer=65536 \
        clone --bare "$HTTPD_URL/smart/repo.git" split.git 2>err &&
    {
        test_have_prereq HTTP2 ||
        grep "^=> Send header: Transfer-Encoding: chunked" err
    }

  +++ GIT_TRACE_CURL=true
  +++ git -c http.postbuffer=65536 clone --bare https://127.0.0.1:5559/smart/repo.git split.git
  error: last command exited with $?=128
  not ok 30 - large fetch-pack requests can be sent using chunked encoding
  # 
  #     GIT_TRACE_CURL=true git -c http.postbuffer=65536 \
  #         clone --bare "$HTTPD_URL/smart/repo.git" split.git 2>err &&
  #     {
  #         test_have_prereq HTTP2 ||
  #         grep "^=> Send header: Transfer-Encoding: chunked" err
  #     }
  # 
rimrul commented 1 month ago

t5559.30

I think that's a regression in curl 8.10.0 that has been fixed in 8.10.1.

https://lore.kernel.org/git/ZuPKvYP9ZZ2mhb4m@pks.im/

dscho commented 1 month ago

I concur. This seems to be Homebrew having upgraded to cURL v8.10.0; It's hitting git/git's CI, too.

While Homebrew did upgrade to v8.10.1 yesterday, the macos-13 runner images were most recently updated 3 days ago and only include cURL v8.10.0, which contains the bug.

Now, we could update Homebrew every time we run CI, but... that would regress on a work-around git/git specifically introduced to avoid breaking CI builds due to Homebrew changing things around that require ci/install-dependencies.sh to adapt.

So I fear that the only thing we can do is to wait.

The good news is that we'll probably not have to wait all that long: From looking at the history of the runner-images' included software, I get the impression that they are updated on a weekly cadence; It looks like the intervals are between 6-9 days which makes me believe that they are supposed to happen on the same weekday but sometimes are delayed for one reason or another, and the schedule is not adjusted in relation to those delays.

dscho commented 1 month ago

Judging by this announcement which is placed prominently at the top of the current list of included software of the macos-13 runners, I would expect this here ticket to be addressed on Sep 23rd or very soon thereafter.

dscho commented 1 month ago

Turns out that I cannot wait it out: v2.46.2 crashed this party! So I opened #5165 to address this issue so that Git for Windows v2.46.2's CI builds won't show it as broken.