search

git-for-windows / git

A fork of Git containing Windows-specific patches.
http://gitforwindows.org/
Other
8.28k stars 2.51k forks source link

Git for windows crashed in Windows 10 latest build (14251.1000) #627

Closed likidu closed 8 years ago

likidu commented 8 years ago

Hi,

I got Git crash immediately running under latest insider build of 14251.1000. I knew its arguable about the "latest" one, but please help. Thank you.

Git for Windows version 2.7.0.

lashchev commented 8 years ago

Same problem here :-(

alexsh commented 8 years ago

Same problem here, error module is ntdll.dll, exception code: 0xc0000005

dscho commented 8 years ago

People. Please read our issue reporting guidelines and improve this report accordingly. Anything else will only result in major frustration on all sides, and that is not what anybody would possibly want.

paladox commented 8 years ago

I also get this problem when using git command. It crashes git. I also get Segmentation fault inside the git program.

dscho commented 8 years ago

@paladox and you also do not list precise version informations as well as a precise account (preferably with a copy-paste of the output) of what you did. Really, please read the issue reporting guide lines. It is really frustrating to receive so incomplete information.

paladox commented 8 years ago

Sorry. When running git --version I get Segmentation fault because of git command being faulty in the latest windows 10 insider build as of 27/01/2016. Also I am running 2.7.0 64-bit.

paladox commented 8 years ago

@dscho All I do is start git bash from the windows start button then in git bash I do this command git to test it. And returns Segmentation fault.

dscho commented 8 years ago

Did you try cmd, what commands crash, etc etc etc etc etc

paladox commented 8 years ago

yes. As soon as I enter git in cmd running as admin it brings up the crash dialog for git for windows.

Also when starting git ui I get this error popup

cannot determine git version:

child kild: segmentation violation

git gui requires git 1.5.0 or later.

dscho commented 8 years ago

What happens when you run net use /? in cmd?

paladox commented 8 years ago

When I run net use /? it brings up the Net Command has stopped working.

Briles commented 8 years ago

I'm having the same issue in Windows 10 14251.1000 64-bit and 64-bit Git versions later than 2.6.2.windows.1

Running installed or portable git.exe results in Git for Windows has stopped working error message and logs the following in Event Viewer:

Faulting application name: git.exe, version: 2.7.0.0, time stamp: 0x00000000
Faulting module name: ntdll.dll, version: 10.0.14251.1000, time stamp: 0x56a54488
Exception code: 0xc0000005
Fault offset: 0x00000000000a6eeb
Faulting process id: 0xc50
Faulting application start time: 0x01d159deab2de7c2
Faulting application path: C:\PortableGit-2.7.0-64-bit\mingw64\bin\git.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report Id: 31967d76-6b7d-4e9f-af3b-40ae2867739c
Faulting package full name: 
Faulting package-relative application ID:

Running net use /? results in:

Faulting application name: net.exe, version: 10.0.14251.1000, time stamp: 0x56a54798
Faulting module name: ucrtbase.dll, version: 10.0.14251.1000, time stamp: 0x56a5447e
Exception code: 0xc0000005
Fault offset: 0x0000000000021415
Faulting process id: 0xf58
Faulting application start time: 0x01d159dbc6b316a7
Faulting application path: C:\WINDOWS\system32\net.exe
Faulting module path: C:\WINDOWS\system32\ucrtbase.dll
Report Id: 89cf4fbc-8269-41c7-8595-970945bda050
Faulting package full name: 
Faulting package-relative application ID:

Git-gui also fails to start with:

Cannot determine Git version:
child killed: segmentation violation
Git Gui requires Git 1.5.0 or later.

Running git from Bash results in:


Brian@Brian-PC MINGW64 /
$ git --version
Segmentation fault
jaccarmac commented 8 years ago

Running git from CMD results in a "Git for Windows has stopped working" message. Running the command from Git Bash results in a segmentation fault.

Windows 10 rs1_release 14251, Git, 2.7.0.0.

Log Name:      Application
Source:        Application Error
Date:          28-Jan-16 10:24:27
Event ID:      1000
Task Category: (100)
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      valentine
Description:
Faulting application name: git.exe, version: 2.7.0.0, time stamp: 0x00000000
Faulting module name: ntdll.dll, version: 10.0.14251.1000, time stamp: 0x56a54488
Exception code: 0xc0000005
Fault offset: 0x00000000000a6eeb
Faulting process id: 0x1188
Faulting application start time: 0x01d159f0bd604efe
Faulting application path: C:\Program Files\Git\mingw64\bin\git.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report Id: 26293b56-fb4b-4f4f-a875-399a099f81de
Faulting package full name: 
Faulting package-relative application ID: 
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" />
    <EventID Qualifiers="0">1000</EventID>
    <Level>2</Level>
    <Task>100</Task>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2016-01-28T17:24:27.501423400Z" />
    <EventRecordID>625</EventRecordID>
    <Channel>Application</Channel>
    <Computer>valentine</Computer>
    <Security />
  </System>
  <EventData>
    <Data>git.exe</Data>
    <Data>2.7.0.0</Data>
    <Data>00000000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.14251.1000</Data>
    <Data>56a54488</Data>
    <Data>c0000005</Data>
    <Data>00000000000a6eeb</Data>
    <Data>1188</Data>
    <Data>01d159f0bd604efe</Data>
    <Data>C:\Program Files\Git\mingw64\bin\git.exe</Data>
    <Data>C:\WINDOWS\SYSTEM32\ntdll.dll</Data>
    <Data>26293b56-fb4b-4f4f-a875-399a099f81de</Data>
    <Data>
    </Data>
    <Data>
    </Data>
  </EventData>
</Event>
heldchen commented 8 years ago

same here: Windows 10 Pro Insider Preview x64 build 14251.rs1_release.160124-1059, Git x64, v2.7.0.0.

if the WER reports are of any use, I can provide them privately.

Log Name:      Application
Source:        Application Error
Date:          28.01.2016 18:58:48
Event ID:      1000
Task Category: (100)
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      X-WING
Description:
Faulting application name: git.exe, version: 2.7.0.0, time stamp: 0x00000000
Faulting module name: ntdll.dll, version: 10.0.14251.1000, time stamp: 0x56a54488
Exception code: 0xc0000005
Fault offset: 0x00000000000a6eeb
Faulting process id: 0x3188
Faulting application start time: 0x01d159f589ae1376
Faulting application path: C:\Program Files\Git\mingw64\bin\git.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report Id: 67e92489-a5fa-4010-9adf-8d04be5d0f31
Faulting package full name: 
Faulting package-relative application ID: 
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" />
    <EventID Qualifiers="0">1000</EventID>
    <Level>2</Level>
    <Task>100</Task>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2016-01-28T17:58:48.285256200Z" />
    <EventRecordID>655</EventRecordID>
    <Channel>Application</Channel>
    <Computer>X-WING</Computer>
    <Security />
  </System>
  <EventData>
    <Data>git.exe</Data>
    <Data>2.7.0.0</Data>
    <Data>00000000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.14251.1000</Data>
    <Data>56a54488</Data>
    <Data>c0000005</Data>
    <Data>00000000000a6eeb</Data>
    <Data>3188</Data>
    <Data>01d159f589ae1376</Data>
    <Data>C:\Program Files\Git\mingw64\bin\git.exe</Data>
    <Data>C:\WINDOWS\SYSTEM32\ntdll.dll</Data>
    <Data>67e92489-a5fa-4010-9adf-8d04be5d0f31</Data>
    <Data>
    </Data>
    <Data>
    </Data>
  </EventData>
</Event>
Log Name:      Application
Source:        Windows Error Reporting
Date:          28.01.2016 18:58:50
Event ID:      1001
Task Category: None
Level:         Information
Keywords:      Classic
User:          N/A
Computer:      X-WING
Description:
Fault bucket 120399744865, type 4
Event Name: APPCRASH
Response: Not available
Cab Id: 0

Problem signature:
P1: git.exe
P2: 2.7.0.0
P3: 00000000
P4: ntdll.dll
P5: 10.0.14251.1000
P6: 56a54488
P7: c0000005
P8: 00000000000a6eeb
P9: 
P10: 

Attached files:
C:\ProgramData\Microsoft\Windows\WER\Temp\WER4CE5.tmp.WERInternalMetadata.xml
C:\Users\Me\AppData\Local\Temp\WER54C6.tmp.appcompat.txt

These files may be available here:
C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_git.exe_d792d3b2e130c95f532e21b8c261b227ab646c8_da76d18a_36f75532

Analysis symbol: 
Rechecking for solution: 0
Report Id: 67e92489-a5fa-4010-9adf-8d04be5d0f31
Report Status: 1
Hashed bucket: 97b4e7a1d26115cd399602c67e2da1ff
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Windows Error Reporting" />
    <EventID Qualifiers="0">1001</EventID>
    <Level>4</Level>
    <Task>0</Task>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2016-01-28T17:58:50.532295500Z" />
    <EventRecordID>656</EventRecordID>
    <Channel>Application</Channel>
    <Computer>X-WING</Computer>
    <Security />
  </System>
  <EventData>
    <Data>120399744865</Data>
    <Data>4</Data>
    <Data>APPCRASH</Data>
    <Data>Not available</Data>
    <Data>0</Data>
    <Data>git.exe</Data>
    <Data>2.7.0.0</Data>
    <Data>00000000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.14251.1000</Data>
    <Data>56a54488</Data>
    <Data>c0000005</Data>
    <Data>00000000000a6eeb</Data>
    <Data>
    </Data>
    <Data>
    </Data>
    <Data>
C:\ProgramData\Microsoft\Windows\WER\Temp\WER4CE5.tmp.WERInternalMetadata.xml
C:\Users\Me\AppData\Local\Temp\WER54C6.tmp.appcompat.txt</Data>
    <Data>C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_git.exe_d792d3b2e130c95f532e21b8c261b227ab646c8_da76d18a_36f75532</Data>
    <Data>
    </Data>
    <Data>0</Data>
    <Data>67e92489-a5fa-4010-9adf-8d04be5d0f31</Data>
    <Data>1</Data>
    <Data>97b4e7a1d26115cd399602c67e2da1ff</Data>
  </EventData>
</Event>
kowsheek commented 8 years ago

Same issue here

Log Name:      Application
Source:        Application Error
Date:          1/28/16 2:33:34 PM
Event ID:      1000
Task Category: (100)
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      KATRA
Description:
Faulting application name: git.exe, version: 2.7.0.0, time stamp: 0x00000000
Faulting module name: ntdll.dll, version: 10.0.14251.1000, time stamp: 0x56a54488
Exception code: 0xc0000005
Fault offset: 0x00000000000a6eeb
Faulting process id: 0x1da4
Faulting application start time: 0x01d15a02c7130628
Faulting application path: C:\Program Files\Git\mingw64\bin\git.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report Id: cf21ce19-c83a-46d1-9a44-3dba8a9e6971
Faulting package full name: 
Faulting package-relative application ID: 
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Application Error" />
    <EventID Qualifiers="0">1000</EventID>
    <Level>2</Level>
    <Task>100</Task>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2016-01-28T19:33:34.754836400Z" />
    <EventRecordID>1363</EventRecordID>
    <Channel>Application</Channel>
    <Computer>KATRA</Computer>
    <Security />
  </System>
  <EventData>
    <Data>git.exe</Data>
    <Data>2.7.0.0</Data>
    <Data>00000000</Data>
    <Data>ntdll.dll</Data>
    <Data>10.0.14251.1000</Data>
    <Data>56a54488</Data>
    <Data>c0000005</Data>
    <Data>00000000000a6eeb</Data>
    <Data>1da4</Data>
    <Data>01d15a02c7130628</Data>
    <Data>C:\Program Files\Git\mingw64\bin\git.exe</Data>
    <Data>C:\WINDOWS\SYSTEM32\ntdll.dll</Data>
    <Data>cf21ce19-c83a-46d1-9a44-3dba8a9e6971</Data>
    <Data>
    </Data>
    <Data>
    </Data>
  </EventData>
</Event>
sailro commented 8 years ago

Same issue here, but probably due to this Windows build in my opinion (Windows 10 Pro Insider Preview x64 build 14251.rs1_release.160124-1059). Git 2.7.0 x32 or x64 is completely broken, unable to run Git (the installer is also failing when trying to call git). Git 2.6.2 works locally, but I cannot pull or push (git-remote-https was unable to start correctly error code 0x0000142).

net use /? is also crashing on my machine. Unhandled exception at 0x00007FFADBED1415 (ucrtbase.dll) in net.exe: 0xC0000005: Access violation writing location 0x00000000000019D0.

Looking at this windows build changelog: Known issues: •Due to a recent memory management change, you may see periodic app crashes or other memory related app errors. The workaround is to reboot your PC.

...

kowsheek commented 8 years ago

@sailro I restarted several times (before reinstall and after) no luck.

I installed git version 1.9.4.msysgit.0 and it seems to be working with push and no crashes as yet.

shiftkey commented 8 years ago

It was brought to my attention by @onovotny that you should be able to workaround this issue by installing an earlier version of Git for Windows:

For those people running into git crashes on Windows 10 14521, install 2.6.1 (it'll downgrade higher vers): https://github.com/git-for-windows/git/releases/tag/v2.6.1.windows.1 https://twitter.com/onovotny/status/692538905539780609

clairernovotny commented 8 years ago

Seems like 2.6.2 also works.

sailro commented 8 years ago

@onovotny 2.6.2 works locally but crash with network actions (pull/push). I will try 2.6.1 then 1.9.x

sailro commented 8 years ago

@onovotny 2.6.1 crash also with network actions (pull/push)

clairernovotny commented 8 years ago

awesome! isn't it great to be on beta OS code :)

FWIW, there is a note in the release notes that things may crash in this build due to changes in the memory manager. I would expect this to be fixed in the next build or two; I doubt there's really any need to fix anything in Git.

sailro commented 8 years ago

I love that :(. After next release I will opt out

clairernovotny commented 8 years ago

So now the Q is what's the latest version that works? :)

sailro commented 8 years ago

https://github.com/msysgit/msysgit/releases/tag/Git-1.9.5-preview20150319 works

sailro commented 8 years ago

We have to rollback to the 1.9.x generation with msysgit

clairernovotny commented 8 years ago

Or us VS 2015 with LibGit2 to do network ops, at least until the next build ;)

How about a PowerShell script that wraps LibGit2 to do push/pull/fetch?

paladox commented 8 years ago

I rolled back to prevous build and now git works.

darrelmiller commented 8 years ago

Just as a point of reference, I'm running GFW 3.0.11.2 on Win10 14251.rs1_release.160124-1059 on a Surface Pro 3 and I am not seeing any issues.

singhkays commented 8 years ago

@darrelmiller I'm currently broken with the 3.0.12.0 GFW update on that build but I believe GFW ships with it's own version of a portable git. Look under %LocalAppData%\GitHub

shiftkey commented 8 years ago

@darrelmiller @singhkay GitHub Desktop ships v2.5.3 and my testing suggests anything network related is silently failing right now. I'm also investigating to give a more solid repro so we can see just what has been impacted here.

dscho commented 8 years ago

isn't it great to be on beta OS code :)

@onovotny could you imagine what such a comment does to somebody who did work (unlike you) on this bug for the entire day yesterday?

dscho commented 8 years ago

So for everybody who actually appreciates that they can sit in the peanut gallery, doing exactly nothing while waiting for others to work on Open Source:

I have to test this a bit more, but it looks as if the -fstack-protector-strong flag we introduced with version 2.6.3 causes a bad interaction with the changes in said internal build. It will take quite a substantial time, still, to figure out exactly what is going wrong, but if my further tests indicate that this is indeed the only culprit here, I will remove that flag for the next release. My hunch is that libcurl might have been compiled with the same flag, which would be consistent with the problems with git-remote-https.exe (but then also fetch should have the problem, I missed whether that was tested at all).

dscho commented 8 years ago

isn't it great to be on beta OS code :)

@onovotny could you imagine what such a comment does to somebody who did work (unlike you) on this bug for the entire day yesterday?

@onovotny just to make sure that you understand: this lack of respectful tone is not acceptable in the Git for Windows project, as per our code of conduct by which I also expect bug reporters and even commenters like you to abide.

By your own choosing you are but a guest in this project, and now I am forced to ask you to exercise a friendly tone. It cannot be in your interest, either, to distress the developers who help you by fixing the problems you experience; We definitely deserve so much better. However satisfying that venting might have been for you in the moment, it now forces me to enforce the code of conduct, which is unfair for two reasons: it is highly unpleasant for me, and it also further distracts me quite a bit from doing what I actually want to do: make Git for Windows better.

So let's stop all that dissonant conversation now and continue in an appropriate manner.

shiftkey commented 8 years ago

@dscho

but if my further tests indicate that this is indeed the only culprit here, I will remove that flag for the next release

As the one who encouraged this change, I'm :thumbsup: to dropping that flag now to help ameliorate the situation until we can get to the root of the problem.

My hunch is that libcurl might have been compiled with the same flag, which would be consistent with the problems with git-remote-https.exe (but then also fetch should have the problem, I missed whether that was tested at all)

This is interesting - and might explain why i can see Git for Windows 2.5.3 (the one we ship in GitHub Desktop - and before -fstack-protector-strong was incorporated) silently failing when doing fetch/push/pull.

e.g.

> $env:GIT_TRACE=1
> $env:GIT_CURL_VERBOSE=1
> git fetch
18:10:56.754347 git.c:348               trace: built-in: git 'fetch'
18:10:56.766506 run-command.c:335       trace: run_command: 'git-remote-https' 'origin' 'https://github.com/octokit/octokit.net.git'
>

Is there anything I can do to help move this along?

dscho commented 8 years ago

Hey @shiftkey, thanks for chiming in (and helping actively).

Is there anything I can do to help move this along?

I had a brief look at the mingw-w64-x86_64-curl package and it seems that it does have code in ltmain.sh that looks at the -fstack-protector flag (note that also the weak form triggered this bug here, and it seems to be related to code in compat/mingw.c because I do not get the crash with the flag but without mingw.o in libgit.a (which does require a ton of hacks to be able to link)).

At this point, I think the safest bet is for me to continue, unless you have cycles to spend on rebuilding mingw-w64-x86_64-curl?

dscho commented 8 years ago

I love that :(. After next release I will opt out

@sailro Please note that while it might have given you momentary relief to vent like this, the effect it has on developers who try to fix this bug is horrible. That is why we ask in our code of conduct to keep the tone friendly and patient.

It is also in your own best interest to do so: such comments do nothing but delay the fix. So let's go back to a constructive conversation.

shiftkey commented 8 years ago

@dscho I've punched out for the week (and am kind of exhausted from unrelated stuff achieved this week) but I'll have a read over those links when I get a quiet moment on Monday morning.

Happy hunting!

dscho commented 8 years ago

@shiftkey no worries! I know you work hard (and you certainly worked hard for Git for Windows previously), so you did your due. Will keep you updated via this ticket.

takkuumi commented 8 years ago

@dscho How long can you solve this problem ,I cant work now.

heldchen commented 8 years ago

@dscho I have just noticed that the curl.exe file from the git mingw package also fails in the same manner as git.exe. but if i read your comment regarding

At this point, I think the safest bet is for me to continue, unless you have cycles to spend on rebuilding mingw-w64-x86_64-curl?

correct, you probably already know this as well... thanks for your continued efforts!

dscho commented 8 years ago

@NateLing I am sorry that you cannot work now, but if you really need this so badly, you should consider putting some effort into fixing this yourself. It is Open Source for that reason, after all, that you are empowered to fix things that do not work for you.

dscho commented 8 years ago

So here is a temporary (unsigned) installer that Works For Me (except fetching/pushing via HTTPS): https://github.com/dscho/git/releases/download/v2.7.0.windows.1.win10.14251/Git-2.7.0-win10.14251-64-bit.exe. Note: this file will go away, and is provided only for your information. If it is not working for you or eats your children, you have been warned.

paladox commented 8 years ago

Could it be this know issue in that build causing the problem

Due to a recent memory management change, you may see periodic app crashes or other memory related app errors. The workaround is to reboot your PC.

Please try rebooting your computer and see if that works.

clairernovotny commented 8 years ago

@dscho Wow....first, my response was totally sarcasm, not any kind of insult on anyone working on Git (or anything else). My apologies if it was misinterpreted.

Microsoft has said repeatedly that the beta builds will break things. In this case, it broke Git, which is hugely inconvenient for all of us.

That said, it is a beta. I would not expect this to continue or be in the released OS. My main point, if any, is that this is a Windows bug, not a Git bug and so it's on them to fix it.

Oren

dscho commented 8 years ago

Please try rebooting your computer and see if that works.

@paladox it does not fix it here.

dscho commented 8 years ago

first, my response was totally sarcasm

@onovotny And my response made it clear that it is not at all appreciated, yes?

dscho commented 8 years ago

@onovotny and please note that you clarification, while you probably intended well, still takes me away from further work on this bug.

clairernovotny commented 8 years ago

@dscho as you wish

dscho commented 8 years ago

@onovotny it has nothing to do with "as I wish". Do you want me to work on the bug or to be distracted by the issue tracker? As you wish...