git-gurus-itu-devops / itu-minitwit

0 stars 0 forks source link

Use SHA as docker image version for testing #46

Closed A-Guldborg closed 3 months ago

A-Guldborg commented 3 months ago

When deploying to our staging environment, we do not use the latest tag to build or pull an image. We should do the same for testing.

Currently there is a slight risk when running multiple workflows simultaneously, that a deploy-workflow builds the :latest image and then when it is about to pull, another testing-workflow that comes from a pull request will overwrite the :latest image and cause this image to be deployed to production. Similarly when multiple test-flows are running, they might use the wrong pull request's changes when pulling from Docker Hub.