git-gurus-itu-devops / itu-minitwit

0 stars 0 forks source link

Feature/e2e test #53

Closed fredpetersen closed 5 months ago

silkeholmebonnen commented 6 months ago

Nu parser testene men den failer på sonarcloud med duplicate code. Hvad skal der gøres for at fikse det @MadsRoager @A-Guldborg ?

A-Guldborg commented 6 months ago

@MadsRoager I am not 100% certain, but might this be fixed by #54 in which we define our test code directories? Are we able to configure the maximum duplicate lines / duplication settings for our sonarcloud setting which only relates to test code?

@silkeholmebonnen in general, I think we will very quickly see a lot of code duplication and I suppose 3% might be too low for this project. But setting it to higher than 20.6% to allow e.g. this PR might be too high? However, in cases like this I think we just need to verify that the duplicate lines are okay and not actually code duplication in production code and then manually override once all other tests passes but if we can fix it with test-specific settings that'd be optimal!

A-Guldborg commented 6 months ago

Det ser ikke ud til vi bare lige kan re-runne static code analysis fra SonarCloud nu når #54 er merget, men prøv at rebase det her PR og så burde vi kunne se om det virker :)

fredpetersen commented 6 months ago

Har haft rebased, de er stadigvæk røde. Virker til at der er noget der stadigvæk ikke helt spiller

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud