Closed GoogleCodeExporter closed 9 years ago
Is this the only thing that breaks? I would have thought some of the code that
tries to define Atomic32 and Atomic64 would have trouble here as well, but
maybe not?
Smart to use UINTPTRMAX in the preprocessor! I would have thrown in another
configure step; ugly.
Original comment by csilv...@gmail.com
on 13 Apr 2011 at 8:25
Original comment by csilv...@gmail.com
on 13 Apr 2011 at 8:27
That was the only thing that kept the --enable-minimal build from compiling.
I abandoned using tcmalloc in the context where I was looking at it, so I
didn't actually get as far as checking that things really work. That said,
the toolchain is likely to change to stop predefining x86_64.
But also, on further reflection there I would have made it: MIN(48,
8*sizeof(void*)).
Original comment by mcgra...@google.com
on 13 Apr 2011 at 9:01
Yes, I agree that's better. I'll make the change that way.
Original comment by csilv...@gmail.com
on 14 Apr 2011 at 12:07
This should be fixed in perftools 1.8, just released.
Original comment by csilv...@gmail.com
on 16 Jul 2011 at 1:27
Original issue reported on code.google.com by
mcgra...@google.com
on 8 Apr 2011 at 5:26Attachments: