search

git-kick / ioBroker.e3dc-rscp

Manage E3/DC power station based on RSCP
GNU General Public License v3.0
26 stars 10 forks source link

Please fix issues reported by adapter checker #222

Closed mcm1957 closed 3 months ago

mcm1957 commented 4 months ago

❗ [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommened ❗ [E033] @iobroker/adapter-core 2.5.1 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json ❗ [E036] @iobroker/testing 2.5.4 specified. 4.1.3 is required as minimum, 4.1.3 is recommended. Please update devDependencies at package.json ❗ [E182] Please remove "common.license" from io-package.json as "common.licenseInformation" is declared. 👀 [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation" 👀 [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead. 👀 [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI". 👀 [W202] Version of package.json (1.3.0) doesn't match latest version on NPM (1.2.6) 👀 [W521] "gulp" found at devDependencies at package.json but no "gulpfile.js" found. Is this dependency really required? 👀 [W522] Please consider migrating to admin 5 UI (jsonConfig).

git-kick commented 4 months ago

Thank you for the list of issues - most of them seem trivial, but: I failed to fix some them for hours because the github action (test-and-release.yml) and the adapter checker seem to have different, inconsistent criteria, e.g.

I am not sure how to keep the package-files up-to-date, perhaps you have a hint for me how to continuously maintain those files.

mcm1957 commented 4 months ago

Only the outdated test requires common.license. Please Update testing to current Release and checks should be in sync.

mcm1957 commented 3 months ago

replaced by #224