search

git-kick / ioBroker.e3dc-rscp

Manage E3/DC power station based on RSCP
GNU General Public License v3.0
26 stars 10 forks source link

Please consider fixing issues detected by repository checker #232

Closed ioBroker-Bot closed 1 month ago

ioBroker-Bot commented 1 month ago

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter e3dc-rscp for common errors and appropiate suggestions to keep this adapter up to date.

This check is based the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.e3dc-rscp

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release

ERRORS:

:thumbsup: No warnings found

:thumbsup: No suggestions found

Please review issues reported and consider fixing them as soon as appropiate.

Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.

You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:

@iobroker-bot recheck @iobroker-bot recreate

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users. Let's work together for the best user experience.

your ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Fri, 13 Sep 2024 11:18:35 GMT based on commit cfbcbe17a6746baf5ea1ada617c11d604c841242 ioBroker.repochecker 3.0.5

git-kick commented 1 month ago

I think this is a false positive. README.md already has the suggested bottom line.

mcm1957 commented 1 month ago

Please copyright clause move to top of license section. See other adapters.

The first copyright detected (and used) is 'Copyright (C) 2007 Free Software Foundation, Inc. https://fsf.org/' Not sure if this is correct at all as fsf holds most likely no copyright at the adapter code. The topmost copyright line should always be the most actual line.

git-kick commented 1 month ago

ok. will do so. many thanks!

git-kick commented 1 month ago

@iobroker-bot recheck

ioBroker-Bot commented 1 month ago

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested. No changes detected.

git-kick commented 1 month ago

The first copyright detected (and used) is 'Copyright (C) 2007 Free Software Foundation, Inc. https://fsf.org/' Not sure if this is correct at all as fsf holds most likely no copyright at the adapter code. The topmost copyright line should always be the most actual line.

The 2007 fsf copyright is part of the license text, which I included unchanged.

git-kick commented 1 month ago

@iobroker-bot recheck

ioBroker-Bot commented 1 month ago

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested. No changes detected.

git-kick commented 1 month ago

@iobroker-bot recheck

ioBroker-Bot commented 1 month ago

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested. No changes detected.

git-kick commented 1 month ago

@iobroker-bot recheck

mcm1957 commented 1 month ago

Please see https://github.com/git-kick/ioBroker.e3dc-rscp/pull/234 This PR should fix the issue.

The copyright line must be at top of license section - not before the license section. :-)

ioBroker-Bot commented 1 month ago

This issue has been updated by ioBroker Check and Service Bot

RECHECK has been performed as requested. No changes detected.

git-kick commented 1 month ago

@ioBroker-Bot recheck

ioBroker-Bot commented 1 month ago

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed [E605] No actual year found in copyright. Please add "Copyright (c) 2024 Ulrich Kick iobroker@kick-web.de" at the end of README.md

:thumbsup:Thanks for fixing the issues.

RECHECK has been performed as requested.

ioBroker-Bot commented 1 month ago

All issues reported earlier seem to be fixed now. THANKS for your support.
This issue will be closed.

your
ioBroker Check and Service Bot