Some commands break the level

x3rAx commented 3 years ago

Hi there,

this game is an awesome idea :)

But I found some commands that break the current level and I have to go back to the level selection and start over when I type them.

The commands I encountered were:

vim
vi
nano
git commit --amend

Also after I close the game, I see the following errors in the terminal:

ERROR: ~List: Condition "_first != __null" is true.
   At: ./core/self_list.h:112
ERROR: ~List: Condition "_first != __null" is true.
   At: ./core/self_list.h:112
WARNING: cleanup: ObjectDB instances leaked at exit (run with --verbose for details).
     At: core/object.cpp:2135
ERROR: clear: Resources still in use at exit (run with --verbose for details).
   At: core/resource.cpp:477
ERROR: There are still MemoryPool allocs in use at exit!
   At: core/pool_vector.cpp:69

bleeptrack commented 3 years ago

Hey @x3rAx ! Thanks for bringing this up! So, for vim/vi/nano etc we replaced these commands with our own text editor called 'fake-editor'. But it seems this editor is not opening for you? Could you try:

Opening a text editor via GUI (for example by clicking on a text file)
Opening the fake-etitor via command line: f.e.: $ fake-editor testfile.txt Thanks!

x3rAx commented 3 years ago

Hi @bleeptrack ! I tried it again with the latest version. When I try to open a file e.g. with vim filename I get the following error:

C:/Users/x3ro/AppData/Roaming/Oh My Git/tmp/commandXXXXXXXXXX: line 1: fake-editor: command not found

But when I just enter e.g. "vim" the input field is disabled, vim is still visible in the input field and nothing more happens. The input stays disabled until I click one of the available action cards (e.g. for git pull) or until I exit and restart the level.

Here is a short clip demonstrating the behavior.

Edit

Using the GUI to open files works fine but using fake-editor also results in command not found.

git-learning-game / oh-my-git

Some commands break the level #109

Edit