git-learning-game / oh-my-git

An interactive Git learning game!
https://ohmygit.org
Other
2k stars 146 forks source link

Not clear instructions on the "Your first commit" level #50

Open clayms opened 3 years ago

clayms commented 3 years ago

An error is reported if the user tries to only input git commit as they will need to provide a commit message with the -m flag, or git will have to open an editor. However, in Windows, the git you are using for this game cannot open an editor.

lmbaker commented 3 years ago

My friend had the same or a similar issue, also on Windows. I believe he is playing on the version from itch.io. I asked him to try typing the command and using the drag-and-drop card, and both produce the same problem. I had him try adding a commit message, as in git commit -m "my commit message", and that works correctly.

Here is the screenshot he sent me:

ohmygit-error-censored

There is one more line cut off by this screenshot that reads "Please supply the message using either -m or -F option."

I hope this helps, let me know if you need more info and I'll ask.

blinry commented 3 years ago

Thanks for reporting and sending the screenshot! Hmm, the scripts/fake-editor Perl script is supposed to be the mechanism to open an editor in-game. It will ping the game on port 1234. This is quite a hack, but the best solution we found. Maybe the firewall prevented this in both these cases? @clayms, do you also get the error message about the fake-editor?