search

git-learning-game / oh-my-git

An interactive Git learning game!
https://ohmygit.org
Other
2k stars 145 forks source link

German umlauts are discarded in editor area #74

Open UweSauter opened 3 years ago

UweSauter commented 3 years ago

Environment: Arch Linux glibc 2.33-4

$ locale
LANG=de_DE.UTF-8
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER="de_DE.UTF-8"
LC_NAME="de_DE.UTF-8"
LC_ADDRESS="de_DE.UTF-8"
LC_TELEPHONE="de_DE.UTF-8"
LC_MEASUREMENT="de_DE.UTF-8"
LC_IDENTIFICATION="de_DE.UTF-8"
LC_ALL=

When doing a commit by CLI the editor is opened with the default commit template. All umlauts that should be present are missing in the text.

blinry commented 3 years ago

Thanks for letting us know, we were able to reproduce this! It seems like the built-in editor invoked by the scripts/fake-editor script doesn't handle UTF-8 correctly. Uh, any Perl programmers around? :D