search

git-moss / ConvertWithMoss

Converts multisamples from a source format (WAV, multisample, KMP, wavestate, NKI, SFZ, SoundFont 2) to a different destination format.
https://www.mossgrabers.de/Software/ConvertWithMoss/ConvertWithMoss.html
GNU Lesser General Public License v3.0
173 stars 13 forks source link

[RFC] Renoise Instrument support #11

Closed napcode closed 2 years ago

napcode commented 2 years ago

Hi,

Out of curiosity, I started to look into adding Renoise/Redux instrument support. Turns out, this format is very similar to the ones already there (like Bitwig multisample). This PR is not meant to be merged but I'm rather looking for feedback, help and input.

The detector part is basically working. The creator part is not yet implemented. The biggest hurdle though is the fact that Renoise/Redux allows using any supported sample format in the instrument files. The important ones are WAV and FLAC, whereas the latter is being used in every instrument I've looked at so far. So, before going any further, I would like to ask a few questions:

  1. Would you consider merging such a PR at all?
  2. Is it acceptable to drag in another 3rd party dependency? (like jflac)
  3. The last time I wrote java code was literally 15 years ago :blush:. Hence, integrating a transcoding step into the code is not very obvious to me yet. Do you have any pointers or ideas? Is there a preferred way of doing it? Did you think about this already? To me it seems the best way is to put this into the creator as only the destination format knows what sampleformats are being supported. The drawback might be, that every creator might need to deal with that somehow eventually.

Thanks for your help! Maybe this is not the best way to discuss this. If you happen to be a matrix user: @napcode:matrix.org

git-moss commented 2 years ago

1) This was already asked by some people, so, yes this would be a welcome addition. Having said that, I have to point out that I do these projects mainly on my own since I do not have the time to discuss with other people or being left with code I cannot support. 2) In general yes, needs to match the license, should be on Maven central. 3) Currently, the only conversion happening is merging mono left/right WAV files to stereo WAV files. Luckily so far all formats supported/use WAV files. If your source needs other formats they should be converted before handed over to a creator.

napcode commented 2 years ago

Thanks for these answers so far.

  1. I was asking in the KVR thread about Renoise support btw. I do understand your concerns about the maintainability of the code. I was actually hoping for a small diff but the transcoding probably blows up the diff considerably.
  2. That seems to be the case with jflac. I'll give it a try.

I'll close the PR for now and reopen it once it is more useful.