search

git-moss / ConvertWithMoss

Converts multisamples from a source format (WAV, multisample, KMP, wavestate, NKI, SFZ, SoundFont 2) to a different destination format.
https://www.mossgrabers.de/Software/ConvertWithMoss/ConvertWithMoss.html
GNU Lesser General Public License v3.0
190 stars 13 forks source link

Problem when converting to .xpm #7

Closed ShoveD01 closed 2 years ago

ShoveD01 commented 2 years ago

Noticed that the end loop point is the actual sample end not the embedded end loop point. When converting from .sf2 to .xpm

git-moss commented 2 years ago

Up to my knowledge there is only a loop start but the end is automatically the sample end. At least that is what I could figure out via the MPC user interface. There might be more options but since there is no documentation for the xpm format available that's how it is.

ShoveD01 commented 2 years ago

I understand what your saying , but that’s not always the case it would seem. I converted a soundfont to .xpm . The original had a seamless loop whereas the converted had a pop, when I looked at the original, the loop end point was about a few samples short of the sample end point

Sent from my iPad

On 8 Dec 2021, at 15:25, Jürgen Moßgraber @.***> wrote:

 Up to my knowledge there is only a loop start but the end is automatically the sample end. At least that is what I could figure out via the MPC user interface. There might be more options but since there is no documentation for the xpm format available that's how it is.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ShoveD01 commented 2 years ago

What I’m trying to say is the embedded loop end point becomes the sample end point as far as the Mpc is concerned.

Sent from my iPad

On 8 Dec 2021, at 15:25, Jürgen Moßgraber @.***> wrote:

 Up to my knowledge there is only a loop start but the end is automatically the sample end. At least that is what I could figure out via the MPC user interface. There might be more options but since there is no documentation for the xpm format available that's how it is.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

git-moss commented 2 years ago

Can you send me the file?

ShoveD01 commented 2 years ago

Will do , I’m away at the moment, will do it in a couple of days.

Sent from my iPad

On 8 Dec 2021, at 18:47, Jürgen Moßgraber @.***> wrote:

 Can you send me the file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ShoveD01 commented 2 years ago

Hi don’t think I can attach a file to a message through git hub , do you have an email? Steve

Sent from my iPad

On 8 Dec 2021, at 18:47, Jürgen Moßgraber @.***> wrote:

 Can you send me the file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

git-moss commented 2 years ago

You can attach files here as well. If it is too big just upload it the hoster of your choice and send me a PM.

ShoveD01 commented 2 years ago

Hopefully attached a soundfont which has a loop end slightly less than the sample end . As you will be able to tell when converted this makes a differences. Regards Steve

Sent from my iPad

ShoveD01 commented 2 years ago

 Hi, Here’s a link to “Flute p.sf2” in my Dropbox:

https://www.dropbox.com/s/20ev7tyvj6xidml/Flute%20p.sf2?dl=0

Sent from my iPad

On 9 Dec 2021, at 16:51, Jürgen Moßgraber @.***> wrote:

 You can attach files here as well. If it is too big just upload it the hoster of your choice and send me a PM.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

git-moss commented 2 years ago

Thanks. Will have a look.

git-moss commented 2 years ago

Seems I did not set the loop end but always the sample end. Will be fixed in the next update.

ShoveD01 commented 2 years ago

Hi thanks that will be great , good work by the way , very useful application, hope you don’t mind another suggestion, when converting a sf2 bank, in which more than one of the individual instruments references the same sample, the resulting conversion would be much smaller if the all the .xpm files and the samples with original names were all in the same folder. Rather than in separate folders and therefore duplicating the samples. Hope that’s clear. Regards Steve

Sent from my iPad

On 10 Dec 2021, at 22:11, Jürgen Moßgraber @.***> wrote:

 Seems I did not set the loop end but always the sample end. Will be fixed in the next update.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

lentferj commented 2 years ago

I tried with latest version (fe4aef7850662fe85d5d9e8bc47f71ffa31d6fbf). It seems that now for converting SFZ to XPM the sample end is always set to "1" when looking at the keygroup with "Program Edit". AR DX5 Glitter.sfz.txt AR DX5 Glitter.xpm.txt

ShoveD01 commented 2 years ago

Hi thanks , but don’t you mean sf2 not sfz? Steve

Sent from my iPad

On 13 Dec 2021, at 17:27, Jan Lentfer @.***> wrote:

 I tried with latest version (fe4aef7). It seems that now for converting SFZ to XPM the sample end is always set to "1" when looking at the keygroup with "Program Edit". AR DX5 Glitter.sfz.txt AR DX5 Glitter.xpm.txt

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

lentferj commented 2 years ago

No, I mean sfz, sf2 seems to be fine for me. Probably has been introduced in b431c3a4fc296ae3f186c565cfe0fe692678eb83. There is quite some sfz related stuff in there.

ShoveD01 commented 2 years ago

Didn’t you see the problem in the sf2 file I sent?

Sent from my iPad

On 13 Dec 2021, at 20:34, Jan Lentfer @.***> wrote:

 No, I mean sfz, sf2 seems to be fine for me. Probably has been introduces in b431c3a

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

lentferj commented 2 years ago

I think it is a different problem but maybe introduced when fixing what you described for sf2. But @git-moss will have to have a look at it.

lentferj commented 2 years ago

Or rather here https://github.com/git-moss/ConvertWithMoss/commit/fe4aef7850662fe85d5d9e8bc47f71ffa31d6fbf#diff-7a101d5046ded408af644b664f06c5975902ad1e269ee08b593b47700995d301

I assume sampleLoop.getEnd () does return 1 here for some reason or rather -1 looking at the resulting xpm

`

-1` which my MPC One probably interprets as 1, probably an unsigned int, as negative numbers do not make much sense here.
git-moss commented 2 years ago

Could you please send me the audio files as well? Not sure why there is a loop with no end information, might be a broken file or I am missing something.

And please create new issues for new ones.

lentferj commented 2 years ago

AR DX5 Glitter.zip sure..

lentferj commented 2 years ago

.. and the original SFZ AR DX5 Glitter sfz.zip

I am quite sure it worked with the older version of the converter ... well, except the looping.

Also, the loop info seems to be there in the single samples - when I open it with "Sample Edit" on my MPC One, the looping is just fine. The info seems to be missing in the keygroup only.

lentferj commented 2 years ago

I tried 9216c0e03693a4ed49814b15d67de2452157f5bb with a few of my non-working examples. Looks very good now.. thanks

git-moss commented 2 years ago

I also released version 4.5 today, which includes all these fixes.