git-time-metric / gtm

Simple, seamless, lightweight time tracking for Git
MIT License
973 stars 52 forks source link

[bug] `gtm status` does not respect `-terminal-off` #97

Open devkabiir opened 5 years ago

devkabiir commented 5 years ago

I'm on windows 10 x64 Following is the output I get regardless of the -terminal-off flag

λ gtm status -terminal-off=false -total-only
1h15m0s
λ gtm status -terminal-off=true -total-only
1h15m0s

However gtm report does respect the -terminal-off flag.

I've also tried these flag variations, all output the same

  1. Not specifying the flag
  2. Using --terminal-off
  3. Using --terminal-off=true/false

Also,

λ gtm -version
v1.3.5

Note: Regarding #50, I have a custom script that execute gtm record -terminal before every command is executed in windows.

mschenk42 commented 5 years ago

Thanks for the bug report. We will investigate.

desaroger commented 5 years ago

I downloaded and builded from source some hours ago, and I just checked and for me gtm status works as expected. I also can write the flags in any form and always works:

Testing in Ubuntu 16.04. So maybe is something windows-related.

You tried simply -terminal-off (only one dash)? it's not in the things you said you tried, and I think it's the way that the command help shows.

Also, as maybe you have (or going to have) the source code and compiling from there soon, you can log what the command is receiving, i.e. the raw args in string form, and try to check what is going on. Also running the tests would be a good idea. I doubt something windows-related will be shown in the tests, but it's worth trying.

devkabiir commented 5 years ago

You tried simply -terminal-off (only one dash)? it's not in the things you said you tried, and I think it's the way that the command help shows.

Yes I did, and to make sure I tried again

It has the same output.

Also, I have tried this with admin(superuser/root) and non-admin mode for windows