Closed kominak closed 5 years ago
I've hit this as well in my own testing. Odd that it's introduced only with this new OS considering it looks like it could be a memory smasher or something. I'll give it some time to get to second beta and perhaps start looking at it then. If anyone else wants to try debugging this, that would be nice.
It looks like the FS watcher for a directory is getting kFSEventStreamEventFlagRootChanged
for garden-variety events, which lead to us freeing the underlying git_repository
for a GCRepository
, which then makes all objects attached to it likely to cause a crash.
The replacement of _repository
is denoted with // TODO: Is this really safe?
, which it appears it is not. I'm investigating the removal of that, as well as the faulty event stream (I'll pass a bug report to Apple for that if I think it's necessary, but I haven't seen else like this in the beta so far).
On macOS 10.15 Catalina Beta 1 the app crashes pretty often. It can launch and run for some time, but it crashes most often when:
It's not 100% reproducible, though, which is weird. But it feels as if it's a question of when it fails, not if.
I know I'm running an unstable OS in an early beta, but I thought maybe it's nice to be prepared for the upcoming update.
Version: 1.0.11 (1027) macOS 10.15 Beta 1 (19A471t)