search

git-up / GitUp

The Git interface you've been missing all your life has finally arrived.
http://gitup.co
GNU General Public License v3.0
11.49k stars 1.25k forks source link

Add horizontal width constraint for the toolbar navigation control #807

Closed bogdanbolchis closed 2 years ago

bogdanbolchis commented 2 years ago

On macOS 12.2.1 (Monterey) the three button segmented control is clipped on the right side, making the "Stashes View" segment shorter than normal.

This change adds a width constraint on the segmented controls, which fixes the problem on 12.2.1.

bogdanbolchis commented 2 years ago

Hi all!

This bugfix PR should help with a visual issue on macOS 12 (Monterey). Here is a screenshot of the issue:

Screenshot 2022-03-08 at 14 45 03

This should be tested on previous macOS versions. Unfortunately I don't have access to macOS < 12.

lucasderraugh commented 2 years ago

Thanks for looking into this! It bothers me that this needs a constraint at all considering it resolves itself if you readjust the window size. In theory the intrinsic content size should be enough with the given constraints, though clearly that isn't the case. I'll try it out this weekend and I'll take this change if I don't see an obvious resolution.

JokerQyou commented 2 years ago

...it resolves itself if you readjust the window size. ...

It's strange that if I manually resize the window by dragging at the border the issue resolves itself; but when using window manager utilities (like Magnet) to set window to half the screen width it does not.

lucasderraugh commented 2 years ago

@bogdanbolchis I ended up going with just fixing the widths of the segmented control 628f48bdee34466bcecaa49cc3a313e47086acf8. I appreciate you doing this so long ago and I apologies for not giving quicker turnaround.

bogdanbolchis commented 1 year ago

Thanks! I also noticed today for the first time that resizing the window updates the width and fixes it. If i knew this maybe i would have skipped a PR. No idea why the intrinsic size isn’t honored, though i did see a bunch of AutoLayout warnings in the same xib. Also i’m not sure if that’s influencing layout.

On 8 Mar 2022, at 15:50, Lucas Derraugh @.***> wrote:

 Thanks for looking into this! It bothers me that this needs a constraint at all considering it resolves itself if you readjust the window size. In theory the intrinsic content size should be enough with the given constraints, though clearly that isn't the case. I'll try it out this weekend and I'll take this change if I don't see an obvious resolution.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

danielsaadaudajr commented 1 year ago

Great, thanks.

On Tue, Oct 11, 2022, 7:30 AM bogdanbolchis @.***> wrote:

Thanks! I also noticed today for the first time that resizing the window updates the width and fixes it. If i knew this maybe i would have skipped a PR. No idea why the intrinsic size isn’t honored, though i did see a bunch of AutoLayout warnings in the same xib. Also i’m not sure if that’s influencing layout.

On 8 Mar 2022, at 15:50, Lucas Derraugh @.***> wrote:

 Thanks for looking into this! It bothers me that this needs a constraint at all considering it resolves itself if you readjust the window size. In theory the intrinsic content size should be enough with the given constraints, though clearly that isn't the case. I'll try it out this weekend and I'll take this change if I don't see an obvious resolution.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub https://github.com/git-up/GitUp/pull/807#issuecomment-1274215150, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3CDCXUSDFDJ2DEP32BD75LWCUJQBANCNFSM5QGM3XBQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>