search

git-up / GitUp

The Git interface you've been missing all your life has finally arrived.
http://gitup.co
GNU General Public License v3.0
11.48k stars 1.25k forks source link

Remove libgit2 submodule. #858

Open lolgear opened 2 years ago

lolgear commented 2 years ago

It is possible to remove last submodule libgit2.

Steps are:

  1. Decide where to keep binary dependencies ( in separate repository "libraries" or in libgit2 repository ).
  2. Add binary targets to libgit2 package. ( Again, depends on step 1 how to do it ).
  3. Move Package.swift into libgit2.
  4. Add Swift package to GitUpKit.xcodeproj.
  5. Set proper requirements for package. ( Point to branch/commit/version ).

If we are planning to update libgit2 not frequently, I suggest to put all binaries into libgit2 repository itself in, for example, BinariesFrameworks folder.

@lucasderraugh What do you think?

If you decide to keep binaries in separate repository, then, we need to create new repository and put scripts and binaries into it. Also we need to setup SPM package in it.

OdNairy commented 1 year ago

Looks like this ticket can be closed.

lolgear commented 1 year ago

Looks like this ticket can be closed.

How did this thought come to your mind? Repository still contains submodule libgit2.

OdNairy commented 1 year ago

Looks like this ticket can be closed.

How did this thought come to your mind? Repository still contains submodule libgit2.

My bad. Mixed with binary libssl2