Refactoring. MRC removal. Part three.

git-up / GitUp

The Git interface you've been missing all your life has finally arrived.

http://gitup.co

GNU General Public License v3.0

11.48k stars 1.25k forks source link

Refactoring. MRC removal. Part three. #873

Closed lolgear closed 12 months ago

lolgear commented 1 year ago

kit: interface graph mrc has been removed.

This PR is third PR in series of MRC removal PRs. Part two. https://github.com/git-up/GitUp/pull/857

This PR removes MRC from

GIGraph

lolgear commented 1 year ago

@lucasderraugh I suggest to remove internal usage of CF entities in favor of bridged NS ones with proper ARC handling. It's very hard to investigate why and where/when CF* entities are leaking.

For example, GIGraph have a lot of CF arrays which can be easily bridged to NS arrays without changing interface of GIGraph.

lolgear commented 1 year ago

@lucasderraugh Can you review this PR?

lucasderraugh commented 12 months ago

Closing this out as I had to make various fixes to resolve analyzer compilation. Merged majority of the changes into master.

lolgear commented 12 months ago

Can we remove MRC completely? It will unlock SPM support and it would be easier to merge other PRs

lucasderraugh commented 12 months ago

Well it broke a bunch of stuff when we introduced it last time, I reverted the part 1 and 2 as I didn't have time to fix whatever issues were introduced.