search

git-up / GitUp

The Git interface you've been missing all your life has finally arrived.
http://gitup.co
GNU General Public License v3.0
11.48k stars 1.25k forks source link

1.3.3: Double-clicking a branch or commit in the main view crashes #877

Closed jfirebaugh closed 1 year ago

jfirebaugh commented 1 year ago

Double-clicking a branch or commit in the main view crashes. The crash is 100% reproducible. It does not happen in 1.3.2.

Crash report: https://gist.github.com/jfirebaugh/3d7fc18ea3ca9d208829ab0c91f94d5c

lucasderraugh commented 1 year ago

@jfirebaugh Always when the stable comes out that the issues come in 😅. My first guess is that it has something to do with the MRC to ARC migration changes we tried to make so we could move away from some manual reference counting code. The odd thing is that I'm unable to reproduce this on my own machine (M1 Max on Ventura).

Could you see if simply selecting a commit and hitting return (which should be the same as double-click) results in the same crash loop?

I can try giving you a build that reverts the ARC changes and see if that resolves your issue as well. I'll try to give that either tonight or tomorrow to you. In the meantime, you can use an old version of GitUp as we save all the releases on GitHub.

jfirebaugh commented 1 year ago

Selecting a commit and hitting return does not crash.

Happy to help debug further if you need!

lucasderraugh commented 1 year ago

@jfirebaugh Is it any commit or is there something special about the commit that fails? Either way I'll give you a build to try tomorrow most likely.

jfirebaugh commented 1 year ago

It seems to be any commit in one particular repository (a big private monorepo with a long commit history). Other repositories I've tested are not affected.

lucasderraugh commented 1 year ago

@jfirebaugh Btw I was able to reproduce this issue on a larger repo. I'm going to see if the ARC transition changes were the issue (most likely the case) and if reverting those changes resolves the issue I'll push out a new stable build reverting them.

lucasderraugh commented 1 year ago

@jfirebaugh This should be fixed now in 1.3.4. I made some poor ARC transition decisions that ended up not being equivalent to what MRC had previously.

Let me know if for some reason you are still having this problem.

jfirebaugh commented 1 year ago

Confirmed, 1.3.4 works. Thanks!