search

git-up / GitUp

The Git interface you've been missing all your life has finally arrived.
http://gitup.co
GNU General Public License v3.0
11.45k stars 1.24k forks source link

UI became very laggy ... recent system changes include upgrading from macOS 12 to MacOS 13.1 (Ventura) #906

Open breathe opened 1 year ago

breathe commented 1 year ago

I can't be sure that upgrading to ventura is when the lagginess started -- however its driving me crazy as pretty much every ui interaction -- (eg right-clicking on a commit in the timeline view) involves a 500 ms to 4s delay (with a spinner -- or therabouts) ...

This wasn't ever part of my experience in the past ... Any chance this is a known regression when running gitup on ventura?

lucasderraugh commented 1 year ago

Yikes, I'm not aware of any such regression. Does the version matter (ie does 1.3.2 have the same problem as latest 1.3.5)? Does the repo size that you're operating on matter?

NikKovIos commented 1 year ago

@breathe can you tell the version of GitUp?

richardtop commented 1 year ago

I can confirm this, version 1.3.5 is when the problem has occurred:

image
lucasderraugh commented 1 year ago

With any commit on any repo? I don't seem to have this issue on my end running latest Ventura. Perhaps a sample during the spin would be helpful? You can take it in Activity Monitor or Terminal.

breathe commented 1 year ago

Apologies for my delayed response to previous questions -- missed some notifications and forgot to come back to this ...

I am also on Version 1.3.5

Also -- a refinement to the repo steps for me as I've been playing with and trying to collect more details. I think I have a refinement of the repo steps ... It seems that for me the spinner happens if I right-click on the very most recent commit for a branch ... but not if I right-click on an earlier commit on the branch ...

a sample during the spin

I attempted this -- I clicked the 'sample' button in Activity Profiler and then just after right clicked in gitup in a way that triggers the spinner -- and I think the sample includes that time period

Sample of GitUp.txt

any repo?

hmm well ... so I dug into this more and it seems to be significantly worse in one repo than other repo's I checked ... but the repo that demonstrates the issue is not that big of a repo ...

ncohen@m1-max-toast ~/f/ops (main)> du -hs .
2.8G    .

I downloading the llvm project repo to get another large repo to look at

ncohen@m1-max-toast ~/s/llvm-project (main)> du -hs .
4.1G    .

And the problem doesn't manifest for me in that repo either ...

One idea for maybe something unusual about this git repo ... -- This particular project uses a 'squash merge only' strategy for pull requests -- so that makes its hard to automatically cleanup all my local branches ... This means I've got a ton of local branches lying around which still show up in timeline view ...

try with gitup v1.3.2

I can't get the issue to repro for me with v1.3.2 ... seems more performant even if I click on the branch head

lucasderraugh commented 1 year ago

Thanks, I'll try to find some time to look into the sample. I appreciate the help!