Amending causes buffer over-read

git-up / GitUp

The Git interface you've been missing all your life has finally arrived.

http://gitup.co

GNU General Public License v3.0

11.45k stars 1.24k forks source link

Amending causes buffer over-read #926

Open semyonf opened 1 year ago

semyonf commented 1 year ago

long-commit-message.txt

Steps to reproduce:

create a commit with a message of length = 4758 ASCII characters (WebStorm generated such a message due to conflicts)
press "Amend HEAD"

lucasderraugh commented 1 year ago

Hmm, I'm unable to reproduce the issue as stated. My steps:

Create a commit called "Test"
Stage 1 file and paste in the "ssss..." text from your attached document
Click Amend Head

semyonf commented 1 year ago

@lucasderraugh nonono, you should've committed the "ssss.." and then clicked "Amend HEAD". Comitting "Test" was not necessary actually

lucasderraugh commented 1 year ago

Hmm, even if I do that I don't seem to have this issue. I made a commit with "sss..." (text from text file) then opened the commit view and hit "Amend HEAD" but it just filled in all the sss... like I would expect.

I'll try to look into it a bit more though to see how the Amend HEAD functionality works.

lucasderraugh commented 1 year ago

Ah, I was actually able to reproduce it. Still not sure where things are going awry, but I should be able to dig in now. Thanks!