git-up / GitUp

The Git interface you've been missing all your life has finally arrived.
http://gitup.co
GNU General Public License v3.0
11.45k stars 1.24k forks source link

Use proper quotation marks around user-facing quoted text #931

Open mdznr opened 1 year ago

mdznr commented 1 year ago

Actual: \"%@\" Expected: “%@”

This happens in a number of places in the app, like: https://github.com/git-up/GitUp/blob/5ba30836e6e1fa4ac4d8f908b1522443b470fc92/GitUpKit/Extensions/GCLiveRepository%2BUtilities.m#L25

lucasderraugh commented 1 year ago

Not sure I quite understand what you're saying here. Are you saying you want smart quotes instead of just of a standard quotation mark?

Screenshot 2023-05-03 at 10 16 12 AM
mdznr commented 1 year ago

Yep. That would be more typographically correct.