search

git-wotr / spec

Securely review git commits
Other
3 stars 3 forks source link

Drop the `priority` metadata field #8

Closed Ekleog closed 6 years ago

Ekleog commented 6 years ago

The priority metadata field is problematic in that it can't be marked as “solved” (at least not without re-doing a review). As such, I'm currently thinking that it should be transmitted off-band, which would be much more flexible.

/cc @oxij

oxij commented 6 years ago

Like I said in the very first proposal for this, I imagine "priority" to be just a comment, it might as well be the first word of the comment field. It just makes sense to me make it a separate field because if you then would "subscribe" to a signing key. E.g. I plan to write a git-wotr command to dump new reviews commited into a branch into RFC822 messages for my Maildir for local indexing in notmuch, hence, I could then filter reviews by people I normally "subscribe to" via notmuch filtering (except it's not "subscription" by a combination of "you usually comment in the same threads with that person, let me add it to inbox" and Bayesian filter) by "priority", which seems like a nice addition.

I.e. what I want it to mean is this:

do-I-think-you-should-read-this-too (don't-bother|maybe|yes|absolutely)
oxij commented 6 years ago

Also related https://github.com/git-wotr/spec/pull/10#issuecomment-427919142. Priority can be just an optional x-priority.

Ekleog commented 6 years ago

Hmm… I was thinking that sounded like a rare use case, until noticing it could also be done by other tools, like an aggregator that would take all forks it knows about of a repository and turn all the reviews it can find into RSS feeds or whatever…

@lrvick Any opinion on that matter? :)

Ekleog commented 6 years ago

Current discussion is leaning towards most keywords vanishing anyway, either in favor of x-* keywords or in favor of content-type. Closing as discussion specific to priority no longer makes sense.