search

git / git-reference

Online Git Reference at http://git.github.io/git-reference/
Other
996 stars 363 forks source link

update URL references to fix links & styles #113

Closed shawnajean closed 7 years ago

shawnajean commented 7 years ago

👋 This removes the leading / from src and hrefs in the layout files so that the links work and the styles load again since the custom domain was removed.

matthewmccullough commented 7 years ago

Thanks for this update, @shawnajean. ❤️

shawnajean commented 7 years ago

I based the change off of the 404 errors I'm seeing in the console on the current Pages site. With the leading /, this CSS file for example is loaded from this URL:

https://git.github.io/css/reset.css

Rather than this URL:

https://git.github.io/git-reference/css/reset.css

The gh-pages branch in my fork is built to Pages, so you can see the results here:

https://shawnajean.github.io/git-reference/

brntbeer commented 7 years ago

as per a quick convo in slack with @shawnajean, im gunna merge this! I have some additional future work that built off this coming soon to a pull request near you