search

git / git-reference

Online Git Reference at http://git.github.io/git-reference/
Other
996 stars 363 forks source link

Add anchors to subsections #75

Closed simeonwillbanks closed 10 years ago

simeonwillbanks commented 10 years ago

Fixes #74

e.g. /inspect/#log-s

screen shot 2014-01-09 at 7 34 58 pm

randomecho commented 10 years ago

If you wanted less markup, you could go with something like:

<h4 id="diff-cached">
simeonwillbanks commented 10 years ago

I suggested and used anchors because the h2 tags use anchors.

However, id attributes are fine with me. Should I refactor?

Thanks! :smile:

matthewmccullough commented 10 years ago

@simeonwillbanks Happy to go either way. I don't want to get in the way of this shipping. I'd love this to have less markup, so if that isn't a bunch of work, let's do it. If it is a bunch of work, then lets ship as is.

Thanks for this valuable contribution for accessibility's sake.

simeonwillbanks commented 10 years ago

@matthewmccullough You're welcome!

bry4n commented 10 years ago

:+1:

simeonwillbanks commented 10 years ago

@matthewmccullough If you have a moment, can you please review my last commit? I hope it's ready to :ship:. If not, let me know.

Thank you for your time! :smile:

matthewmccullough commented 10 years ago

@simeonwillbanks Thanks for the reminder. Got the :+1: so it is now :ship:ed!

simeonwillbanks commented 10 years ago

@matthewmccullough You're welcome and thank you for :ship: ing. :metal: