git / git.github.io

Git Developer Pages (This is NOT the place to discuss Git issues. See: https://git-scm.com/community)
https://git.github.io
305 stars 278 forks source link

Fixed Side Navigation Bar for Seamless Page Navigation #715

Closed OmkarSonawane1230 closed 3 months ago

OmkarSonawane1230 commented 3 months ago

This pull request addresses the issue of the side navigation bar disappearing when scrolling down the page. By making the my content height match window height and overflow of scroll, users can now access menu options without needing to scroll back to the top of the page

chriscool commented 3 months ago

@sivaraam could you take a look at this?

OmkarSonawane1230 commented 3 months ago

@sivaraam I change the navbar position to sticky, but in order to make it work I have to make the #wrapper height to window height and overflow scroll, now the position sticky will work when it is scrolled.

OmkarSonawane1230 commented 3 months ago

@sivaraam

I want to share some problems in the site

I have a solution for it

I think we should change the design for side navigation, I design a layout to solve the problem:

new design for git github io

This design not what I am building it is just for explaining my point, the actual design will be different and can be changed further.

In this layout the side navbar will hide on left side for small screen size, and it can be access by hamburger menu or side swap. Here it can will be easy to determine which menu is selected by the arrow in front of the menu item. there will be no horizontal scroll bar because we are using more horizontal space than before.

chriscool commented 3 months ago

@OmkarSonawane1230 This design looks good to me, but it should be discussed in a separate issue. Could you open a new issue with the above description? Thanks.