Question recognition only match whole words

git4school / git4school-visu

Git4School, a dashboard for supporting teacher interventions in Software Engineering courses

https://git4school.firebaseapp.com/

Apache License 2.0

2 stars 3 forks source link

Question recognition only match whole words #36

Closed F0urchette closed 3 years ago

F0urchette commented 4 years ago

Description

Question recognition in commit messages does not identify a question if it is part of a word

Example : Question labeled 3 will not be recognized within the message "Resolved 3: CRUD"

Steps to reproduce

Add a repository with commits
Choose a commit with a message and select a part of one word
Add this part as a question in the configuration tab
Go to the overview graph and apply a filter for this question

Actual result

No commit is found

Expected result

The commit whose message contains the filtered question is displayed

Hints

InCommit.getQuestion(questions) : questions.includes(element) only allow to match whole words

F0urchette commented 3 years ago

Recognition needs to be more restrictive using keywords :

The keywords will be the Github issue closing keywords : close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved

<keyword> <question_id>:

⚠️ Note the space between the keyword and the question ID but there is no space between the question ID and ":".

F0urchette commented 3 years ago

Here is a diagram illustrating the regex that could be used : question-regex