search

gitKrystan / prettier-plugin-ember-template-tag

A prettier plugin for formatting Ember template tags
MIT License
22 stars 12 forks source link

Usage of only-allow #90

Closed chrisrng closed 11 months ago

chrisrng commented 11 months ago

In the preinstall script we use only-allow which is not a dependency of this project. Can we move this off preinstall for cases where we cannot use npx?

"preinstall": "npx only-allow pnpm",

See https://github.com/gitKrystan/prettier-plugin-ember-template-tag/blob/main/package.json#L36

chriskrycho commented 11 months ago

IIUC from chatting with @chrisrng, the issue here is that npx wants internet access, and many CI boxen don't have it. We should either make it a dev dependency or put this in some other script.

chrisrng commented 11 months ago

Unfortunately we're still hit by the issue with 1.0.1