search

gita / bhagavad-gita-api

Bhagavad Gita API is an open-source API that lets anyone use the text from Srimad Bhagavad Gita in their own web or mobile application(s).
https://rapidapi.com/bhagavad-gita-bhagavad-gita-default/api/bhagavad-gita3
MIT License
183 stars 35 forks source link

Code quality workflow failed in gh actions due to absense of flake8 in environment #8

Closed aahnik closed 3 years ago

aahnik commented 3 years ago

Logs https://github.com/gita/bhagavad-gita-api/runs/2961739738#step:5:109

https://github.com/gita/bhagavad-gita-api/blob/a9ea31a3d9a04a04a5391994cf66ac5bdd5e4370/.pre-commit-config.yaml#L37-L39

pre-commit is using flake8 from local environment

aahnik commented 3 years ago

Possible fix: activate poetry virtual environment in Github actions.

https://github.com/gita/bhagavad-gita-api/blob/a9ea31a3d9a04a04a5391994cf66ac5bdd5e4370/.github/workflows/quality.yml#L10-L16

Deps are installed, but the virtual env is never used.