search

gitawego / cordova-screenshot

screenshot plugin for cordova/phonegap
Other
211 stars 167 forks source link

Remove permission from URI function #125

Closed tricki closed 5 years ago

tricki commented 6 years ago

What is the reason that navigator.screenshot.URI() asks for the WRITE_EXTERNAL_STORAGE permission?

I'm not an Android expert but I just removed the permission check and it still works, without asking the for run-time permission.

So, at least on my phone with Android 6.0.1 it works without requesting the permission. Is it different in other versions?

mgrubinger commented 6 years ago

Confirm. Removing the permission check for screenshot.URI() also works for me on: ✓ Android 8.1 (API Level 27) ✓ Android 5.1 (API Level 22) ✓ Android 4.4.4 (API Level 19)

which makes me assume it's fine to use.

@gitawego do you want me to send a PR?

gitawego commented 6 years ago

yes please @mgrubinger

mgrubinger commented 6 years ago

@tricki This is now merged into the main branch. @gitawego thanks for accepting the PR!