search

gitblit-org / gitblit

pure java git solution
http://gitblit.com
Apache License 2.0
2.28k stars 670 forks source link

Handle Pegdown being declared end-of-life #1165

Open flaix opened 7 years ago

flaix commented 7 years ago

Gitblit uses Pegdown in version 1.5.0 for Markdown processing. Pegdown has been deprecated today. This begs the question how to react to this.

  1. Ignore it, since it works.
  2. Update to the latest available version of Pegdown, 1.6.0, to at least use the latest.
  3. Switch to a different Markdown processor for improved speed and continued development, e.g. the recommended flexmark-java.

@gitblit, since you prefer to support the underdogs, do you have any other Markdown processor in mind that would be an alternative in point 3?

gitblit commented 7 years ago

Hehe. I suppose that's true. Another engine to consider is Atlassian Commonmark.

flaix commented 7 years ago

Flexmark-java is actually a fork of Atlassian Commonmark. I am currently reading up on the differences to see if that fork would bring any benefit. Right now flexmark-java couldn't be used as it requires Java8, while Gitblit still works on Java7. But it will be downgraded to java7 in the next release (or so it is planned).

gitblit commented 7 years ago

Atlassian Commonmark seems like the better bet to me. As for J7 vs. J8, JGit is considering (or already did) drop J7 support. I don't have a problem requiring J8.

flaix commented 7 years ago

Well, I wouldn't want to force Java8 on Gitblit just because of a Markdown parser. I guess it boils down to which library supports all the Markdown extensions currently supported in Gitblit (and then some). But going with something Common Mark compatible sounds like a good idea. If it gets faster than Pegdown, then switching to something else eventually is probably the way to go.

gitblit commented 7 years ago

FYI I just confirmed JGit 4.6, due to drop in a week or so, requires J8.

flaix commented 7 years ago

4.6? I thought it is at 4.4, what happend to 4.5. Gitblit uses 4.1, so maybe 4.4 is a possibility to delay requiring J8 a little more. =) I have the feeling that moving to J8 will break a few Gitblit installations on NAS systems.

gitblit commented 7 years ago

4.5 was released in September.