gitblit-org / gitblit

pure java git solution
http://gitblit.com
Apache License 2.0
2.27k stars 670 forks source link

support for jdk 17? #1420

Open xdev965 opened 2 years ago

xdev965 commented 2 years ago

Gitblit is great,The only problem is that it does not support jdk >=17。Is there plan support? Is there a specific timeline?

flaix commented 1 year ago

Yes, there is the goal to support Java 17. No, there is no specific timeline. I wouldn't say there is any specific timeline with Gitblit. The Java 17 issue is an especially vast one. The problem with Java 17 is that many changes since Java 9, that so far only issued warnings, are now forbidden and the JVM fails to start. This might be possible to work around by setting the --add-opens option. But for how long?

The correct way is to update Gitblit's dependencies to versions that work with Java 17. Its just that they are all very old. Currently Gitblit doesn't start under Java 17 because of Guice. Once Guice is updated to a version that runs under Java 17, there will be problems with Pegdown, i.e. Parboiled. Which cannot simply be updated, but must be completely replaced by another library for Markdown parsing. So I cannot say how long this is going to take.

fbacchella commented 8 months ago

I’m running an instance of gitblit as a war embeded in tomcat 9, running with a Temurin 21 JVM. So far, so good. Adding an automatic module name might be a quick win, see https://dev.java/learn/modules/automatic-module/