search

gitblit-org / gitblit

pure java git solution
http://gitblit.com
Apache License 2.0
2.28k stars 670 forks source link

Error on tag update? #474

Closed gitblit closed 9 years ago

gitblit commented 9 years ago

Originally reported on Google Code with ID 178

What steps will reproduce the problem?
1. Existing tag on origin
2. Point the same tag to another new commit in local machine 
3. Force pushed tag to origin trought gitblit
4. Try to watch the commit on page

What is the expected output? What do you see instead?
The commit details(author, date, hash, etc), and files changed. 
Instead I get an "Internal error Return to home page" message

What version of the product are you using? On what operating system?
Gitblit GO v1.1.0 on CentOS 5

Please provide any additional information below.
Here is the console output of running the gitblit trying to watch the commit

ERROR Error attaching this container for rendering: [Page class = com.gitblit.wicket.pages.CommitPage,
id = 13, version = 0]
org.apache.wicket.WicketRuntimeException: Error attaching this container for rendering:
[Page class = com.gitblit.wicket.pages.CommitPage, id = 13, version = 0]
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1789)
        at org.apache.wicket.Component.onBeforeRender(Component.java:4001)
        at org.apache.wicket.Page.onBeforeRender(Page.java:1555)
        at com.gitblit.wicket.pages.BasePage.onBeforeRender(BasePage.java:107)
        at com.gitblit.wicket.pages.RepositoryPage.onBeforeRender(RepositoryPage.java:393)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.Component.prepareForRender(Component.java:2297)
        at org.apache.wicket.Page.prepareForRender(Page.java:1545)
        at org.apache.wicket.Component.prepareForRender(Component.java:2329)
        at org.apache.wicket.Page.renderPage(Page.java:912)
        at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:261)
        at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
        at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1287)
        at org.apache.wicket.RequestCycle.step(RequestCycle.java:1358)
        at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1465)
        at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
        at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:486)
        at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:319)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1323)
        at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:476)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:119)
        at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:517)
        at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:225)
        at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:937)
        at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:406)
        at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:183)
        at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:871)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:117)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:110)
        at org.eclipse.jetty.server.Server.handle(Server.java:346)
        at org.eclipse.jetty.server.HttpConnection.handleRequest(HttpConnection.java:589)
        at org.eclipse.jetty.server.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:1048)
        at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:601)
        at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:214)
        at org.eclipse.jetty.server.HttpConnection.handle(HttpConnection.java:411)
        at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:535)
        at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:40)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:529)
        at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
        at com.gitblit.wicket.pages.RepositoryPage.getShortObjectId(RepositoryPage.java:302)
        at com.gitblit.wicket.pages.CommitPage$3.populateItem(CommitPage.java:169)
        at org.apache.wicket.markup.repeater.RefreshingView$1.newItem(RefreshingView.java:114)
        at org.apache.wicket.markup.repeater.DefaultItemReuseStrategy$1.next(DefaultItemReuseStrategy.java:71)
        at org.apache.wicket.markup.repeater.DefaultItemReuseStrategy$1.next(DefaultItemReuseStrategy.java:68)
        at org.apache.wicket.markup.repeater.RefreshingView.addItems(RefreshingView.java:189)
        at org.apache.wicket.markup.repeater.RefreshingView.onPopulate(RefreshingView.java:98)
        at org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:131)
        at org.apache.wicket.markup.repeater.AbstractPageableView.onBeforeRender(AbstractPageableView.java:121)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1777)
        ... 39 more

Reported by doropeza on 2012-12-10 18:57:58

gitblit commented 9 years ago 
In the code it appears that this is a submodule-related issue.  Is there a submodule
reference in that commit?

Reported by James.Moger on 2012-12-10 21:49:29

gitblit commented 9 years ago 
Yes the main project has a submodule, the submodule project is browseable without a
problem at the gitblit server.

Reported by doropeza on 2012-12-11 19:30:22

gitblit commented 9 years ago 
It is failing to properly display a submodule change (changed path) in whatever commit
that was.  The submodule is null for some unknown reason.  Is this repo publicly accessible?

Reported by James.Moger on 2012-12-11 19:37:16

gitblit commented 9 years ago 
The gitglit server is running with this access restriction
git.defaultAccessRestriction = CLONE

Both repos are at the same gitblit server like this way...
client/mainproject.git
client/submodule.git

Reported by doropeza on 2012-12-11 20:04:31

gitblit commented 9 years ago 
I forgot, the submodule repo had a forced tag update as the main repository, the tag
name is the same in both repos.

Reported by doropeza on 2012-12-11 20:11:54

gitblit commented 9 years ago 
I don't have a good grasp on what the problem is here.  Is this still an issue for you?

Reported by James.Moger on 2012-12-21 22:02:32

gitblit commented 9 years ago 
I think I have fixed this issue.

Reported by James.Moger on 2013-01-13 23:12:12

gitblit commented 9 years ago 
Fixes deployed in 1.2.1

Reported by James.Moger on 2013-01-16 04:25:08

gitblit commented 9 years ago

Reported by James.Moger on 2013-01-16 04:25:29