gitblit-org / gitblit

pure java git solution
http://gitblit.com
Apache License 2.0
2.28k stars 670 forks source link

Error when GC is left blank #662

Closed gitblit closed 9 years ago

gitblit commented 9 years ago

Originally reported on Google Code with ID 366

What steps will reproduce the problem?
1.Create a new empty Repo
2.No filled GC options (GC is enabled into gitblit.properties)
3.push [save]

What is the expected output? What do you see instead?
quote log:
Caused by: java.lang.IllegalArgumentException: Can not set int field com.gitblit.models.RepositoryModel.gcPeriod
to null value
    at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:164)
    at sun.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:168)
    at sun.reflect.UnsafeIntegerFieldAccessorImpl.set(UnsafeIntegerFieldAccessorImpl.java:80)
    at java.lang.reflect.Field.set(Field.java:680)
    at org.apache.wicket.util.lang.PropertyResolver$FieldGetAndSetter.setValue(PropertyResolver.java:1389)
    ... 53 more

What version of the product are you using? On what operating system?
1.4.0 (screenshot)

Please provide any additional information below.

I think the option to enable GC in gitblit.properties should not have to use by the
force.
Ie: Allow the option of not using it, to skip creation in the form of Repo, if it's
not necessary.

Reported by eguervos on 2014-02-08 19:01:51

gitblit commented 9 years ago

Reported by James.Moger on 2014-02-21 14:44:54

gitblit commented 9 years ago
Fix pushed to master.

Reported by James.Moger on 2014-02-21 14:59:32

gitblit commented 9 years ago
1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21