search

gitblit-org / gitblit

pure java git solution
http://gitblit.com
Apache License 2.0
2.28k stars 670 forks source link

Can't view tickets after commiting patchset #703

Closed gitblit closed 9 years ago

gitblit commented 9 years ago

Originally reported on Google Code with ID 407

What steps will reproduce the problem?
When I commit and push a patchset for a ticket, clicking on the ticket within gitblit
returns an Internal Error.  The log file shows this:

2014-04-14 11:01:12 [ERROR] Error attaching this container for rendering: [MarkupContainer
[Component id = panel]]
org.apache.wicket.WicketRuntimeException: Error attaching this container for rendering:
[MarkupContainer [Component id = panel]]
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1789)
        at org.apache.wicket.Component.onBeforeRender(Component.java:4001)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1777)
        at org.apache.wicket.Component.onBeforeRender(Component.java:4001)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1777)
        at org.apache.wicket.Component.onBeforeRender(Component.java:4001)
        at org.apache.wicket.Page.onBeforeRender(Page.java:1555)
        at com.gitblit.wicket.pages.BasePage.onBeforeRender(BasePage.java:138)
        at com.gitblit.wicket.pages.RepositoryPage.onBeforeRender(RepositoryPage.java:624)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.Component.prepareForRender(Component.java:2297)
        at org.apache.wicket.Page.prepareForRender(Page.java:1545)
        at org.apache.wicket.Component.prepareForRender(Component.java:2329)
        at org.apache.wicket.Page.renderPage(Page.java:912)
        at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:261)
        at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
        at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1287)
        at org.apache.wicket.RequestCycle.step(RequestCycle.java:1358)
        at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1465)
        at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
        at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:486)
        at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:319)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482)
        at com.gitblit.servlet.EnforceAuthenticationFilter.doFilter(EnforceAuthenticationFilter.java:86)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1474)
        at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
        at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
        at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
        at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
        at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1088)
        at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428)
        at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
        at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
        at org.eclipse.jetty.server.Server.handle(Server.java:370)
        at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
        at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:949)
        at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1011)
        at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644)
        at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
        at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
        at org.eclipse.jetty.io.nio.SslConnection.handle(SslConnection.java:196)
        at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:668)
        at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
        at java.lang.Thread.run(Thread.java:744)
Caused by: java.lang.IllegalArgumentException: A child with id 'diffStat' already exists:
[MarkupContainer [Component id = 1]]
        at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:145)
        at com.gitblit.wicket.pages.TicketPage$13.populateItem(TicketPage.java:1158)
        at org.apache.wicket.markup.repeater.RefreshingView$1.newItem(RefreshingView.java:114)
        at org.apache.wicket.markup.repeater.DefaultItemReuseStrategy$1.next(DefaultItemReuseStrategy.java:71)
        at org.apache.wicket.markup.repeater.DefaultItemReuseStrategy$1.next(DefaultItemReuseStrategy.java:68)
        at org.apache.wicket.markup.repeater.RefreshingView.addItems(RefreshingView.java:189)
        at org.apache.wicket.markup.repeater.RefreshingView.onPopulate(RefreshingView.java:98)
        at org.apache.wicket.markup.repeater.AbstractRepeater.onBeforeRender(AbstractRepeater.java:131)
        at org.apache.wicket.markup.repeater.AbstractPageableView.onBeforeRender(AbstractPageableView.java:121)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1777)
        ... 54 more

What is the expected output? What do you see instead?
The ticket info for the bug

What version of the product are you using? On what operating system?
I am using Gitblit 1.4.1 on CentOS 6.5

Please provide any additional information below.

Reported by mike@mcrill.net on 2014-04-14 16:07:10

gitblit commented 9 years ago 
I see the problem.  Will be fixed on master later today and released in 1.5.0 later
this week.

Reported by James.Moger on 2014-04-14 16:15:07

gitblit commented 9 years ago 
Fix pushed to master.

Reported by James.Moger on 2014-04-14 16:33:26

gitblit commented 9 years ago 
Fix/change released in 1.5.0.

Reported by James.Moger on 2014-04-18 13:27:24

gitblit commented 9 years ago

Reported by James.Moger on 2014-04-18 13:27:49