search

gitblit-org / gitblit

pure java git solution
http://gitblit.com
Apache License 2.0
2.28k stars 671 forks source link

Internal Server error after pressing ticket comment twice #858

Open gitblit opened 9 years ago

gitblit commented 9 years ago

Originally reported on Google Code with ID 562

What steps will reproduce the problem?
1. Create a ticket with a commit
2. Add a comment 
3. Press "comment" two times

What is the expected output? What do you see instead?
I would expect that a reload of the page happens and the comment is added once. Instead
I end up with an "internal Server" error.

What version of the product are you using? On what operating system?
1.6.2 WAR in Tomcat on Red Hat Linux 7

Please provide any additional information below.

Exported Ticket info:

{
    "body": "",
    "changes": [
        {
            "author": "user1",
            "date": "2015-02-11T15:50:16Z",
            "fields": {
                "body": "",
                "mergeTo": "build700",
                "status": "New",
                "title": "Add initial solarisstudio module",
                "type": "Proposal",
                "watchers": "+user1"
            },
            "patchset": {
                "added": 0,
                "base": "3d4d77aa180a3ec05b67905c3415a6a949450ae5",
                "commits": 1,
                "deletions": 0,
                "insertions": 213,
                "number": 1,
                "rev": 1,
                "tip": "85becf4c1445870ddd23e5999b5a7e096b476727",
                "type": "Proposal"
            }
        },
        {
            "author": "user1",
            "date": "2015-02-12T07:36:18Z",
            "fields": {
                "responsible": "user2",
                "watchers": "+user2"
            }
        },
        {
            "author": "user1",
            "comment": {
                "id": "2ff36394768c478220a9c9b86187cc75da387954",
                "text": "Package name is wrong / packages are missing.\nI don't think
that there is a service that needs to be running."
            },
            "date": "2015-02-12T07:37:10Z"
        },
        {
            "author": "user1",
            "comment": {
                "id": "e47d26603e663fc36e6297f20d19fac9bfa75dc7",
                "text": "Package name is wrong / packages are missing.\nI don't think
that there is a service that needs to be running."
            },
            "date": "2015-02-12T07:37:12Z"
        }
    ],
    "created": "2015-02-11T15:50:16Z",
    "createdBy": "user1",
    "deletions": 0,
    "insertions": 213,
    "mergeTo": "build700",
    "number": 4,
    "project": "CIT",
    "repository": "department1/IT/puppet_rhel.git",
    "responsible": "user2",
    "status": "New",
    "title": "Add initial solarisstudio module",
    "type": "Proposal",
    "updated": "2015-02-12T07:37:12Z",
    "updatedBy": "user1"
}

Reported by henning.henkel on 2015-02-12 07:51:01

gitblit commented 9 years ago 
2015-02-12 09:33:12 [ERROR] Error attaching this container for rendering: [MarkupContainer
[Component id = discussion]]
org.apache.wicket.WicketRuntimeException: Error attaching this container for rendering:
[MarkupContainer [Component id = discussion]]
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1789)
        at org.apache.wicket.Component.onBeforeRender(Component.java:4001)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.MarkupContainer.onBeforeRenderChildren(MarkupContainer.java:1777)
        at org.apache.wicket.Component.onBeforeRender(Component.java:4001)
        at org.apache.wicket.Page.onBeforeRender(Page.java:1555)
        at com.gitblit.wicket.pages.BasePage.onBeforeRender(BasePage.java:152)
        at com.gitblit.wicket.pages.RepositoryPage.onBeforeRender(RepositoryPage.java:657)
        at org.apache.wicket.Component.internalBeforeRender(Component.java:1069)
        at org.apache.wicket.Component.beforeRender(Component.java:1103)
        at org.apache.wicket.Component.prepareForRender(Component.java:2297)
        at org.apache.wicket.Page.prepareForRender(Page.java:1545)
        at org.apache.wicket.Component.prepareForRender(Component.java:2329)
        at org.apache.wicket.Page.renderPage(Page.java:912)
        at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:261)
        at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:105)
        at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1287)
        at org.apache.wicket.RequestCycle.step(RequestCycle.java:1358)
        at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1465)
        at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
        at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:486)
        at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:319)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
        at com.gitblit.servlet.EnforceAuthenticationFilter.doFilter(EnforceAuthenticationFilter.java:87)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
        at com.gitblit.servlet.ProxyFilter$1.doFilter(ProxyFilter.java:74)
        at com.gitblit.servlet.ProxyFilter.doFilter(ProxyFilter.java:77)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
        at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
        at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:200)
        at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
        at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException

Reported by henning.henkel on 2015-02-12 08:34:30

gitblit commented 9 years ago 
Tomcat makes me sad, but it should work better than that.  There was a little more to
the stacktrace.  Namely the NullPointer part.  I'm not sure if that will be useful,
but upper part of the stacktrace is basically just noise.

Reported by James.Moger on 2015-02-18 04:47:26