Exit codes when "Image cannot be shrunk any further"

justin-robinson commented 8 months ago

If you attempt to shrink an image that can't be shrunk anymore, the command exits with status 1. This was unexpected and requires us to suppress that error code so it doesn't kill our script. I'd argue this isn't an error since the result is what the user wanted, an image that's shrunk as much as possible. What are you thoughts?

# sudo sdm --shrink my.img
* Start shrink on IMG 'my.img'
> Check the file system
rootfs: 52111/215568 files (0.2% non-contiguous), 571790/861981 blocks
resize2fs 1.46.5 (30-Dec-2021)
% Image cannot be shrunk any further

# echo $?
1

We have to do this as a workaroung

# shrink it (always return exit code 0 since sdm sets it to 1 if the image already is the minimum size)
sudo sdm --shrink $1 || true

gitbls commented 8 months ago

Ugh. That one is easy. Please continue posting busted exit statusi, will fix them in the next release.

gitbls commented 8 months ago

Fixed in V11.6. Please test/verify. Thx

gitbls commented 7 months ago

Closing due to no activity. Please re-open or create a new issue if necessary.

gitbls / sdm

Exit codes when "Image cannot be shrunk any further" #192

We have to do this as a workaroung