search

gitbls / sdm

Raspberry Pi SD Card Image Manager
MIT License
471 stars 48 forks source link

Invalid systemd version check #214

Closed ykharuzhy closed 5 months ago

ykharuzhy commented 5 months ago

I noticed this in sdm's output:

sdm-cparse: line 1080: [[: 256~rc3: syntax error in expression (error token is "~rc3")

It caused by interpreting systemd version as number here:

[[ "$vers" -lt "242" ]] && cmode=""

I have systemd 256~rc3. This error doesn't cause any troubles for versions >= 242, of course, but looks 'dirty'.

gitbls commented 5 months ago

Ugh. Will have a look at that. Thx.

gitbls commented 5 months ago

This is corrected in V12.3. Please verify. Thx

ykharuzhy commented 5 months ago

Works, thanks

пт, 7 чэр 2024, 21:11 карыстальнік Benn @.***> напісаў:

This is corrected in V12.3. Please verify. Thx

— Reply to this email directly, view it on GitHub https://github.com/gitbls/sdm/issues/214#issuecomment-2155299111, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIHK77UCGJZKY544HB7SJGTZGHZU5AVCNFSM6AAAAABIWF4D76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGI4TSMJRGE . You are receiving this because you authored the thread.Message ID: @.***>

gitbls commented 5 months ago

Great. Thanks for taking the time to report and validate.