bugfix: radar chart line does not respect chartColors

gitbrent / PptxGenJS

Create PowerPoint presentations with a powerful, concise JavaScript API.

https://gitbrent.github.io/PptxGenJS/

MIT License

3k stars 643 forks source link

bugfix: radar chart line does not respect chartColors #1177

Closed mathbruyen closed 2 years ago

mathbruyen commented 2 years ago

Option chartColors sets the color of markers on a radar chart but is ignored for lines which take Powerpoint's default colors. A comment in examples states that it should be used for markers too:

chartColors: COLORS_RYGU, // marker & line color

In case there is no dataBorder specify, fallback to chartColors.

This is very similar to bubble chart fallback (which is reindented to be be more explicit in the XML elements it creates) except that cap can be parameterized in radar.

mathbruyen commented 2 years ago

Already fixed on master, sorry