search

gitbrent / xlsx-js-style

SheetJS Community Edition + Basic Cell Styles
https://gitbrent.github.io/xlsx-js-style/
Apache License 2.0
390 stars 61 forks source link

Page Layout: Support hiding GridLines for exports #26

Closed Elijah-Oppenheim closed 1 month ago

Elijah-Oppenheim commented 1 year ago

Hello! I wanted to add support for disabling gridlines when generating XLSX files. This isn't something SheetJs provides as part of the community edition (https://github.com/SheetJS/sheetjs/issues/1945). I made the changes myself and wanted to see if you'd want to include them in this project.

Using this commit: https://github.com/SheetJS/sheetjs/issues/927 as a reference point. I expanded the options to support disabling gridlines for exports. Initially, I was going to add this as a custom prop in the WritingOptions/SheetOptions, but ultimately wanted to remain aligned with the openxml schema and opted for another WBView boolean. (https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.spreadsheet.sheetview?view=openxml-2.8.1)

Let me know if you have any feedback!

Elijah-Oppenheim commented 1 year ago

Hey @gitbrent I wanted to know if you saw this. Please let me know if this is something you would like to be merged into the project, otherwise I will close this pull request.

gitbrent commented 1 month ago

Thanks @Elijah-Oppenheim !

Elijah-Oppenheim commented 1 month ago

I am closing this PR as the support will be incorporated into v1.3.0! https://github.com/gitbrent/xlsx-js-style/pull/36/commits