search

gitbucket-plugins / gitbucket-h2-backup-plugin

GitBucket H2 Database Backup Plugin
21 stars 7 forks source link

HTTP call to http://YOUR_GITBUCKET/database/backup should be POST only #24

Open aadrian opened 7 years ago

aadrian commented 7 years ago

The HTTP call to http://YOUR_GITBUCKET/database/backup to create the backup should be POST only, not GET since the remote system is "changing".

Also it should really be secured for admins only, e.g. at least with a Token, so that it can be used with curl or wget.

Thank you.

c0llab0rat0r commented 3 years ago

Each of these issues should be resolved now (using POST, requiring admin, and using api tokens as credentials).

aadrian commented 3 years ago

@c0llab0rat0r This looks great, and also the detailed test suite too! Thank you.

takezoe commented 3 years ago

It's already released. Can we close this?

stevemesser commented 1 year ago

I just update to the latest version of the H2 Backup plugin.

How can I redirect from with the plugin page to save the backup to /media/usb/backups in stead of the default location?

stevemesser commented 1 year ago

Never mind, I just tried a relative path and it worked fine, I could have sworn I tried that and that it didn't work.