search

gitbucket-plugins / gitbucket-plugins.github.io

gitbucket-plugins community site
http://gitbucket-plugins.github.io
13 stars 4 forks source link

Add embedded snipet plugin to list #49

Closed onukura closed 4 years ago

onukura commented 4 years ago

This PR add plugins below to the community list. https://github.com/onukura/gitbucket-embedding-plugin

takezoe commented 4 years ago

Thanks! By the way, as you mentioned in README of this plugin, this feature might have to be implemented on GitBucket side. Do you have any concern about it?

onukura commented 4 years ago

@takezoe At first Thx for merge!

By the way, as you mentioned in README of this plugin, this feature might have to be implemented on GitBucket side. Do you have any concern about it?

Humm... This plugin just add JS on every page and have to search target DOM to replace with another DOM. So I thought it would be better for performance if it's done by renderer. Do you think snippet is ok with this way??

onukura commented 4 years ago

But at same time this way is useful too. It works every .markdown-body.p.a in issue, PR, wiki, repo/README.

onukura commented 4 years ago

@takezoe I think this discussion should be at https://github.com/gitbucket/gitbucket/issues/2485. So I will put comment from now.

takezoe commented 4 years ago

I think this discussion should be at gitbucket/gitbucket#2485. So I will put comment from now.

That makes sense. Let's discuss there.