search

gitbucket / gitbucket-docker

Docker image of GitBucket which is an open source GitHub server powered by Scala
https://github.com/gitbucket/gitbucket-docker/pkgs/container/gitbucket
58 stars 23 forks source link

Docker JRE, base image update #18

Open srbala opened 4 years ago

srbala commented 4 years ago

@takezoe Docker seems using older version of JRE build as base image. https://hub.docker.com/layers/gitbucket/gitbucket/4/images/sha256-909664650e090b5a44c9ac9f696e51cde34e7c79f4367402309ec2361ef20e11

Can we update to adoptopenjdk, thinking of https://hub.docker.com/r/adoptopenjdk/openjdk8-openj9, its OSS with backing of IBM.

If the team agrees, I would like to work on a pull request

takezoe commented 4 years ago

Do you think OpenJ9 is better than HotSpot?

srbala commented 4 years ago

OpenJ9 is base line for IBM JDK, derived from Oracle and IBM combo. HotSpot derivation of Oracle only. OpenJ9 is my personal choice, I have been using it more than a year (previously IBM JDK). We could put multiple docker images, OpenJ9, HotSpot, and Alpine (based images for docker smaller size).

SIkebe commented 4 years ago

AdoptOpenJDK9 is not LTS, so it already EOL'ed in March 2018. https://adoptopenjdk.net/support.html

~~Also GitBucket is currently tested against JDK8 and 11. (both are LTS)~~

SIkebe commented 4 years ago

Ah, I misunderstood..., its OpenJ9 and not OpenJDK9

srbala commented 4 years ago

Yes. Still staying with JDK8 of OpenJ9, LTS version

takezoe commented 4 years ago

I see. Generally speaking, HotSpot seems to be a better choise since it's used widely. However, providing multiple docker images might be a good idea if it doesn't require extra effort to maintain.

srbala commented 4 years ago

Docker Official jdk8 link, 1M+ downloads https://hub.docker.com/_/adoptopenjdk?tab=tags based on ubuntu base image, 205-225MB size. 1M+ downloads.

https://hub.docker.com/search?q=adoptopenjdk%2Fopenjdk8&type=image OpenJ9 jdk8, other system images debian, alpine, centos, and ubi (redhat 8), size 95-170MB. 5M+ downloads.

takezoe commented 4 years ago

I meant the popularity of VM itself, not docker images. However, I understood the advantage of OpenJ9 in terms of image size. If we want to provide a smaller image, OpenJ9 looks a good choice.

aadrian commented 1 year ago

@takezoe from the many OpenJDKs, Zulu JDKs are even better. The Docker images for them: https://github.com/zulu-openjdk/zulu-openjdk