search

gitbucket / gitbucket-docker

Docker image of GitBucket which is an open source GitHub server powered by Scala
https://github.com/gitbucket/gitbucket-docker/pkgs/container/gitbucket
58 stars 23 forks source link

Specific version images and nightly build image #22

Closed onukura closed 4 years ago

onukura commented 4 years ago

It would be very useful if there are more specific images and ideally nightly build image like bellow.

gitbucket/gitbucket:latest
gitbucket/gitbucket:nightly
gitbucket/gitbucket:4.34
gitbucket/gitbucket:4.33
gitbucket/gitbucket:4.32
gitbucket/gitbucket:4.31
...
takezoe commented 4 years ago

Hmm. Tags are not reflected in DockerHub? 🤔

onukura commented 4 years ago

I can see only latest, 4, 3, 4.29.0 ... For example latest ver. 4.34.0, there is tag but not in DockerHub.

takezoe commented 4 years ago

If I remember correctly, when I created 4.29.0 tag on GitHub, it was built on DockerHub automatically. I wonder why it doesn't work now. Maybe additional steps are necessary?

onukura commented 4 years ago

It should be like that normally when tag is created if a setting for build rules in Build configurations is enable. image

onukura commented 4 years ago

@takezoe Or GitHub Actions might be an option for that. I made a trial which use github actions for building tag and nightly build. What do you think about it?
https://github.com/onukura/gitbucket-docker/tree/dev (I removed folder structure because there is already ver. 3 image on Docker Hub)

onukura commented 4 years ago

@takezoe I made draft PR #23, please check when you have time.

takezoe commented 4 years ago

Tag build is not configured on DockerHub and I can't update the configuration for some reason. Maybe there is a problem in GitHub integration?

Screen Shot 2020-08-09 at 17 51 34
onukura commented 4 years ago

@takezoe that is very strange... you can't delete them neither?

takezoe commented 4 years ago

I haven't tried that because I'm not sure if I can re-add them once delete...

onukura commented 4 years ago

@takezoe I see... So more because of this integration issue, why not moving to GitHub Actions(GAs) to publish images #23 ?? While docker hub integration build is passive, GAs can actively control release. And nightly build is easier than docker-hub integration. To do nightly build by docker-hub integration, you might need complicated Dockerfile. please feel free to tell me if it's out of your scope. I will do this in my own repo! ;)

takezoe commented 4 years ago

There is no special reason to avoid using GitHub Actions. I just didn't have enough time to take care of this recently. 🙇

shoud be fine!

onukura commented 4 years ago

@takezoe Great! I updated #23. Now ready for review. This GitHub actions has 3 triggers.

dockerfile trigger docker image tag
Dockerfile push to master branch latest
Dockerfile tag e.g. 4.34.0
Dockerfile-nightly scheduled (0 0 *) nightly
takezoe commented 4 years ago

Thanks! I will take a look.

takezoe commented 4 years ago

Implemented in #23.