404 with custom base url

gitbucket / gitbucket

A Git platform powered by Scala with easy installation, high extensibility & GitHub API compatibility

https://gitbucket.github.io/

Apache License 2.0

9.16k stars 1.26k forks source link

404 with custom base url #1788

Closed elion closed 6 years ago

elion commented 6 years ago

404 with custom base url

Impacted version: 4.19+

Deployment mode: Standalone app behind nginx with custom base url

Problem description:

can not access System Administration, the url ../gitbucket/admin/users responds with 404
Another problem is with testing webhook. Somehow hook (name?) is undefined and I get 404 for url ../settings/hooks/undefined/validate.

Worked before 4.19.0 upgrade.

takezoe commented 6 years ago

When GitBucket isn't deployed document root, some routings didn't work by CompositeScalatraFilter bug. This bug was fixed in bcd92916cab7c23f6530009192539e4c1efb9b24.

In addition, testing web hook causes 404 which you reported in gitter had an another cause. It had been caused by collision of id attribute with the bundled notification plugin. This problem was fixed in d15b3fb2f6d2928fb9eb4e400815864d114bb990.

GitBucket 4.19.2 which includes these fixes is available. Could you try it again? https://github.com/gitbucket/gitbucket/releases/tag/4.19.2

elion commented 6 years ago

I can confirm that these issues have been fixed. Many thanks!