gitbutlerapp / gitbutler

The GitButler version control client, backed by Git, powered by Tauri/Rust/Svelte
https://gitbutler.com
Other
12.62k stars 500 forks source link

Accessibility Feature: Optionally disable scrollbar hiding #4067

Closed iSchluff closed 3 months ago

iSchluff commented 3 months ago

Hi, this might be somewhat of an edge case but I mainly develop using speech control and eye tracking using the awesome https://talonvoice.com/

Using the Gitbutler client right now is a bit of an hassle with the eye tracker, because there is no good way to scroll as the scrollbars are hidden by default. I would like to have an option to disable the scroll bar hiding.

If you agree that this is a worthwhile change I could work on a PR.

krlvi commented 3 months ago

Hey @iSchluff, thank you for reporting this, having the app accessible is important so this is definitely something for us to correct. I think @PavelLaptev had some thoughts around fixing this too

PavelLaptev commented 3 months ago

Hey @iSchluff! Thank you for your feedback. In the application (Profile settings) we have a switcher for the scrollbar.

image

I think what we can do here is to add a third option like this:

image

Here is updated design in Figma link https://www.figma.com/design/FbeLt0yjY9RiNn8MXUXsYs/Client-design?node-id=1507-63554&t=uF2MHe4JyrwcEMfF-1


a PR is welcome, just add me to reviewers when you finish 🙂

H1ghBre4k3r commented 3 months ago

@PavelLaptev just so I get this right: Shouldn't the first one be something like "Show the scrollbar only when you scroll"?

H1ghBre4k3r commented 3 months ago

I just was motivated to create a small PR for this change. Hopefully, this does not interfere with anything you already did, @iSchluff. ^^'

Feel free to leave any review comments you'd like.

Edit: I accidently opened the first PR on my fork. ^^'

PavelLaptev commented 3 months ago

@PavelLaptev just so I get this right: Shouldn't the first one be something like "Show the scrollbar only when you scroll"?

@H1ghBre4k3r Correct! It was a placeholder, updated that to your version. Thanks for noticing 🙏

image
H1ghBre4k3r commented 3 months ago

@PavelLaptev Ah, great!

Apparently, I was not able to assign you as a reviewer for my PR. But fortunately, you already did that yourself. ^^'