gitbutlerapp / gitbutler

The GitButler version control client, backed by Git, powered by Tauri/Rust/Svelte
https://gitbutler.com
Other
12.59k stars 498 forks source link

Git authentication is hidden in Windows #4170

Closed akshaybabloo closed 1 month ago

akshaybabloo commented 3 months ago

Version

0.12.5

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

The image shown in https://docs.gitbutler.com/troubleshooting/fetch-push#available-authentication-methods

image

Is hidden in Windows and setting up git using the projects.json is not documented.

The one mentioned in https://github.com/gitbutlerapp/gitbutler/issues/2915 is also hidden.

How to reproduce

No response

Expected behavior

No response

Relevant log output

No response

Byron commented 3 months ago

Thanks for reporting!

I also think it's confusing that on Windows this setting doesn't exist at all. Rather, I'd expect it to be greyed out with a message saying something akin of "On Windows, only the Git executable is supported right now".

Maybe it is a legitimate bug though if hiding the menu on Windows was never intended.

akshaybabloo commented 3 months ago

Yeah, that will be something good to have.

Byron commented 3 months ago

CC @krlvi who might know something about this. I vaguely remember that at some point Windows started defaulting to using the executable, so maybe the whole UI element was removed then?

krlvi commented 3 months ago

@Byron you are correct - on windows there are no config options to choose from. We can either update the docs or have the thing grayed out instead of being absent on windows. I am leaning towards updating the docs though, because those other auth mechanisms cant be supported on windows (at least not with libgit2)

Byron commented 3 months ago

Thanks! Indeed, the issue is about the usability of the documentation. When it's updated, the issue should be resolved.

krlvi commented 1 month ago

I have updated the docs with this PR https://github.com/gitbutlerapp/gitbutler-docs/pull/25