search

gitbutlerapp / gitbutler

The GitButler version control client, backed by Git, powered by Tauri/Rust/Svelte
https://gitbutler.com
Other
13.4k stars 530 forks source link

handle Yubikey touch sucess #4525

Open williamdes opened 3 months ago

williamdes commented 3 months ago

Version

0.12.15

Operating System

Linux

Distribution Method

deb (Linux)

Describe the issue

The modal should close itself when I touch the Yubikey and git continues to process. And also not prompt for a password (maybe difficult to do)

image

How to reproduce

No response

Expected behavior

No response

Relevant log output

No response

williamdes commented 3 months ago

Ref: https://blog.maxds.fr/ssh-with-yubikey/#g%C3%A9n%C3%A9ration-de-la-clef-r%C3%A9sidente (you will need to translate it)

Byron commented 3 months ago

Thanks for reporting, a very interesting problem to solve!

Does that mean everything 'works' in the background even though the UI doesn't notice it?

What happens if the Submit button is pressed by hand - is the UI happy then an 'in-sync' with what actually happens?

Thanks for the clarification and your help with this.

PS: If you can, a screen-recording would probably also do the trick.

williamdes commented 3 months ago

PS: If you can, a screen-recording would probably also do the trick.

Sorry, no software to do this for now :/ But I will try

Does that mean everything 'works' in the background even though the UI doesn't notice it?

Yes, I touch the Yubikey and I only have to close the modal and continue working. It does not even know that an auth can solve without any click. Some GNOME pin-entry software do this too if I recall correctly.

What happens if the Submit button is pressed by hand - is the UI happy then an 'in-sync' with what actually happens?

When I hit submit it closes the modal. But I guess since it is the git executable behind the process continues on it's own regardless of the modal submit